MediaWiki r75585 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r75584‎ | r75585 (on ViewVC)‎ | r75586 >
Date:21:17, 27 October 2010
Author:hashar
Status:ok (Comments)
Tags:
Comment:
Optional feature to login through HTTPS and come back to HTTP.

Based on an idea by George Herbert <george dot herbert at gmail dot com>
http://lists.wikimedia.org/pipermail/wikitech-l/2010-October/050065.html
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r75607Follow up r75585 : messages.inc entry missinghashar06:35, 28 October 2010
r79860Removes $wgSecureLoginStickHTTPS which was never really used...hashar13:06, 8 January 2011

Comments

#Comment by Siebrand (talk | contribs)   21:29, 27 October 2010

phase3/maintenance/language/messages.inc entry missing.

#Comment by Hashar (talk | contribs)   06:36, 28 October 2010

Entry added in r75607 Marking 'new'

#Comment by Raymond (talk | contribs)   06:50, 28 October 2010

If I see right this functionality cannot work for WMF sites because https://en.wikipedia.org is not defined (this is bug 20643).

Would it be an idea to add $wgHTTPSUrl or similar?

#Comment by Hashar (talk | contribs)   07:12, 28 October 2010

Using https://secure.wikimedia.org/ means having to convert the project from being host based to path based :

 fr.wikipedia.org => wikipedia/fr

In my mind, most admin use the same host, path for both protocols.

#Comment by Ilmari Karonen (talk | contribs)   12:38, 28 October 2010

The current secure server config uses hooks to do URL mangling. If we added a couple here, server admins could use them to implement any URL scheme they wanted. I think at least a "GetLoginURL" hook could be useful.

#Comment by Nikerabbit (talk | contribs)   12:47, 28 October 2010

That sounds overtly specific for a hook. We can have a more general hook and pass the title object to it. Actually we already have one: GetLocalUrl – and it works.

#Comment by Hashar (talk | contribs)   06:28, 29 October 2010

This patch was not meant to install "as is" for WikiMedia special case which is a different issue nor it was intended to support any exotic setup. The secret plan is to make WikiMedia use HTTPS with the same host.

#Comment by ^demon (talk | contribs)   16:15, 29 October 2010

I don't think having two different hostnames for HTTP/HTTPS is that unusual.

#Comment by Hashar (talk | contribs)   16:10, 29 October 2010

see also bug 225

#Comment by Happy-melon (talk | contribs)   23:04, 14 December 2010

$wgSecureLoginStickHTTPS is a horrible name; $wgSecureLoginPerpetuateHttps or something would be better.

#Comment by Hashar (talk | contribs)   10:54, 7 February 2011

wgSecureLoginStickHTTPS is removed by r79860

#Comment by Hashar (talk | contribs)   13:08, 8 January 2011

Marking this rev new since it does implement the http / https functionalities when using the same host + path.

#Comment by Firefishy (talk | contribs)   16:32, 20 September 2011

Does not set returnto on secure Userlogin link.

#Comment by Hashar (talk | contribs)   06:21, 21 September 2011

> Does not set returnto on secure Userlogin link.

Firefishy, can you please report it as a bug at https://bugzilla.wikimedia.org/ ?

#Comment by Firefishy (talk | contribs)   08:58, 21 September 2011

Status & tagging log

  • 21:57, 7 February 2011 Tim Starling (talk | contribs) changed the tags for r75585 [removed: tstarling]
  • 21:57, 7 February 2011 Tim Starling (talk | contribs) changed the status of r75585 [removed: new added: ok]
  • 19:57, 9 January 2011 ^demon (talk | contribs) changed the tags for r75585 [added: tstarling]
  • 13:09, 8 January 2011 Hashar (talk | contribs) changed the status of r75585 [removed: fixme added: new]
  • 06:50, 28 October 2010 Raymond (talk | contribs) changed the status of r75585 [removed: new added: fixme]
  • 06:36, 28 October 2010 Hashar (talk | contribs) changed the status of r75585 [removed: fixme added: new]
  • 21:29, 27 October 2010 Siebrand (talk | contribs) changed the status of r75585 [removed: new added: fixme]