MediaWiki r75582 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r75581‎ | r75582 (on ViewVC)‎ | r75583 >
Date:21:02, 27 October 2010
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
(bug 23194) Special:ListFiles now has thumbnails
Added new message listfiles_thumb
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r75623Follow-up r75582: Fix wrong message key in maintenance scriptraymond19:49, 28 October 2010

Comments

#Comment by Nikerabbit (talk | contribs)   21:08, 27 October 2010

Yay. I think this is a good addition and is towards making Special:NewFiles obsolete. It makes the table a bit crowded though (it already was).

What I don't understand is why you are renaming img_thumb to thumb?

#Comment by Bryan (talk | contribs)   21:12, 27 October 2010

It basically is a fake table column. The way Special:Listfiles and the underlying TablePager works, is that each column in the HTML table should correspond to a column in the database table. formatValue() will be called for each field, and only with the current field. For a thumbnail we need to know img_name, and as such we need a hack to rename thumb to thumb as img_name.

The table could use a UI designer indeed.

Also I was thinking that this page should be listed in the top navigation bar next to "my contributions" as "my uploads"

#Comment by Nikerabbit (talk | contribs)   21:19, 27 October 2010

That explains it indeed.

I'm not sure if new top-level item is the best option, maybe it should be integrated to my contributions in some way or another.

Status & tagging log