MediaWiki r7497 - Code Review

Repository:	MediaWiki
Revision:	< r7496‎ \| r7497 (on ViewVC)‎ \| r7498 >
Date:	15:44, 20 February 2005
Author:	gabrielwicke
Status:	old
Tags:
Comment:	correct include order, user stylesheet needs to be last
Modified paths:	/branches/REL1_4/phase3/includes/Skin.php (modified) (history) (diff)

Diff [purge]

Index: branches/REL1_4/phase3/includes/Skin.php
—	—	@@ -241,6 +241,8 @@
242	242	$action = $wgRequest->getText('action');
243	243	$s = "@import \"$wgStylePath/$sheet\";\n";
244	244	if($wgContLang->isRTL()) $s .= "@import \"$wgStylePath/common/common_rtl.css\";\n";
	245	+ $csspage = $wgContLang->getNsText( NS_MEDIAWIKI ) . ':' . $this->getSkinName() . '.css';
	246	+ $s .= '@import "'.$this->makeUrl($csspage, 'action=raw&ctype=text/css')."\";\n";
245	247	if( $wgAllowUserCss && $wgUser->getID() != 0 ) { # logged in
246	248	if($wgTitle->isCssSubpage() && $this->userCanPreview( $action ) ) {
247	249	$s .= $wgRequest->getText('wpTextbox1');
—	—	@@ -277,9 +279,7 @@
278	280	function doGetUserStyles() {
279	281	global $wgUser, $wgContLang;
280	282
281		~~- $csspage = $wgContLang->getNsText( NS_MEDIAWIKI ) . ':' . $this->getSkinName() . '.css';~~
282		~~- $s = '@import "'.$this->makeUrl($csspage, 'action=raw&ctype=text/css')."\";\n";~~
283		-
	283	+ $s = '';
284	284	if ( 1 == $wgUser->getOption( 'underline' ) ) {
285	285	# Don't override browser settings
286	286	} else {

15:03, 12 September 2011 Meno25 (Talk | contribs) changed the status of r7497 [removed: ok added: old]
14:06, 1 July 2009 ^demon (Talk | contribs) changed the status of r7497 [removed: new added: ok]