MediaWiki r74697 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r74696‎ | r74697 (on ViewVC)‎ | r74698 >
Date:23:20, 12 October 2010
Author:platonides
Status:ok (Comments)
Tags:
Comment:
Follow up r70940. This call should use the hook $result.
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/Linker.php
@@ -1401,7 +1401,7 @@
14021402 # run, and even add them to hook-provided text. (This is the main
14031403 # reason that the EditSectionLink hook is deprecated in favor of
14041404 # DoEditSectionLink: it can't change the brackets or the span.)
1405 - $result = wfMsgExt( 'editsection-brackets', array( 'escape', 'replaceafter', 'language' => $lang ), $link );
 1405+ $result = wfMsgExt( 'editsection-brackets', array( 'escape', 'replaceafter', 'language' => $lang ), $result );
14061406 return "<span class=\"editsection\">$result</span>";
14071407 }
14081408

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r70940Followup r70783. Give doEditSectionLink an extra parameter with the language ...platonides12:30, 12 August 2010

Comments

#Comment by Jpond (Talk | contribs)   04:29, 13 October 2010

This fixes the issue with Extension:DiscussionThreading - thanks!

Status & tagging log

  • 10:40, 30 December 2010 Catrope (Talk | contribs) changed the status of r74697 [removed: new added: ok]
Personal tools
Namespaces

Variants
Views
Actions
Navigation
Support
Download
Development
Communication
Toolbox