MediaWiki r73531 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r73530‎ | r73531 (on ViewVC)‎ | r73532 >
Date:14:00, 22 September 2010
Author:churchofemacs
Status:ok
Tags:
Comment:
cosmetic code changes to r73415 and r73376
Modified paths:

Diff [purge]

Index: trunk/extensions/Renameuser/Renameuser.php
@@ -71,8 +71,8 @@
7272 function wfRenameUserShowLog( $article ) {
7373 global $wgOut;
7474 $title = $article->getTitle();
75 - $oldUserName = User::newFromName( $title->getBaseText() );
76 - if ( ($title->getNamespace() == NS_USER || $title->getNamespace() == NS_USER_TALK ) && ($oldUserName && $oldUserName->getId()==0 )) {
 75+ $oldUser = User::newFromName( $title->getBaseText() );
 76+ if ( ($title->getNamespace() == NS_USER || $title->getNamespace() == NS_USER_TALK ) && ($oldUser && $oldUser->isAnon() )) {
7777 // Get the title for the base userpage
7878 $page = Title::makeTitle( NS_USER, str_replace( ' ', '_', $title->getBaseText() ) )->getPrefixedDBkey();
7979 LogEventsList::showLogExtract( $wgOut, 'renameuser', $page, '', array( 'lim' => 10, 'showIfEmpty' => false,

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r73376don't display renameuserlog on pages of usurped accounts. Thanks to Chzz for ...churchofemacs14:29, 20 September 2010
r73415fixing r73376: error with IP userpageschurchofemacs21:56, 20 September 2010

Status & tagging log

  • 23:05, 2 October 2010 Siebrand (Talk | contribs) changed the status of r73531 [removed: new added: ok]
Personal tools
Namespaces

Variants
Views
Actions
Navigation
Support
Download
Development
Communication
Toolbox