MediaWiki r68831 - Code Review

Repository:	MediaWiki
Revision:	< r68830‎ \| r68831 (on ViewVC)‎ \| r68832 >
Date:	13:43, 1 July 2010
Author:	demon
Status:	ok (Comments)
Tags:
Comment:	Followup r63389: remove useless CACHE_DB and confusing CACHE_ANYTHING from cache setup
Modified paths:	/trunk/phase3/includes/installer/Installer.i18n.php (modified) (history) (diff) /trunk/phase3/includes/installer/WebInstaller.php (modified) (history) (diff)

Diff [purge]

Index: trunk/phase3/includes/installer/Installer.i18n.php
—	—	@@ -406,8 +406,6 @@
407	407	No functionality is removed, but speed may be impacted.',
408	408	'config-cache-accel' => 'PHP object caching (APC, eAccelerator, XCache or WinCache)',
409	409	'config-cache-memcached' => 'Use Memcached (requires additional setup and configuration)',
410		~~- 'config-cache-db' => 'Cache data into the database',~~
411		~~- 'config-cache-anything' => 'MediaWiki will attempt to cache data anywhere possible, except in Memcached, unless indicated explicitely',~~
412	410	'config-memcached-servers' => 'Memcached servers:',
413	411	'config-memcached-help' => 'List of IP addresses to use for Memcached.
414	412	Should be separated with commas and specify the port to be used (for example: 1.2.3.4:56, 7.8.9.10:11).',
Index: trunk/phase3/includes/installer/WebInstaller.php
—	—	@@ -1406,8 +1406,7 @@
1407	1407	$this->parent->getFieldsetEnd()
1408	1408	);
1409	1409
1410		~~- $caches = array( 'none', 'anything', 'db' );~~
1411		~~- $selected = 'db';~~
	1410	+ $caches = array( 'none' );
1412	1411	if( count( $this->getVar( '_Caches' ) ) ) {
1413	1412	$caches[] = 'accel';
1414	1413	$selected = 'accel';

Rev.	Commit summary	Author	Date
r69170	r68831 make sure $selected is set.	mah	08:08, 8 July 2010
r69180	Followup r68831, r69170. Set none as the default cache always, never APC	demon	10:34, 8 July 2010

Rev.	Commit summary	Author	Date
r63389	Add object cache settings to advanced setup. Still needs Memcached servers te...	demon	14:10, 8 March 2010

#Comment by MarkAHershberger (Talk | contribs) 08:04, 8 July 2010

Notice: Undefined variable: selected in /home/mah/domains/winkyfrown.com/public_html/wiki/includes/installer/WebInstaller.php on line 1437

#Comment by ^demon (Talk | contribs) 12:34, 22 July 2010

Should be fixed as of r69180

00:02, 5 December 2010 Reedy (Talk | contribs) changed the status of r68831 [removed: new added: ok]