MediaWiki r67856 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r67855‎ | r67856 (on ViewVC)‎ | r67857 >
Date:15:58, 11 June 2010
Author:vyznev
Status:ok (Comments)
Tags:
Comment:
fix delinking of "older 48" link on Special:NewFiles when the head of the list is hit while browsing forward in time; see http://commons.wikimedia.org/w/index.php?title=Commons:Village_pump&oldid=40386986#Older_48_link_at_Special:Newfiles
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r67863followup to r67856: don't pass null as a query parameter value, even if it se...vyznev19:28, 11 June 2010

Comments

#Comment by Ilmari Karonen (talk | contribs)   16:17, 11 June 2010

I realized after committing that this can sometimes cause array( 'until' => null ) to be passed as the query to $sk->linkKnown(). However, this doesn't actually seem to break anything or even cause warnings(!) -- the null propagates all the way to wfArrayToCGI(), which happily feeds it to urlencode(), which apparently accepts it and returns an empty string. Still, it might be worth explicitly setting it to a non-null value (say, "") rather than relying on this.

Status & tagging log