For MediaWiki (recent comments | status changes | tags | authors | states | release notes | statistics)
Still circumventable via API. Permission checks should be done in IPBlockForm::doBlock itself.
Fixed in r64230.
Code duplication is considered bad in programming because it it doubles (or in this case quadruples) maintenance effort. There should be a static IpBlockForm::checkUnblockSelf that is called in the 4 places that you use it.
Now that makes sense. Done in r64256.
What if an admin accidentally blocks themselves? It's happened quite a bit.
They wait for someone to unblock them, just like everyone else who gets blocked accidentally. The only problem is if there're a limited number of admins on a site; especially if one goes rogue and blocks the others. Which is why it should be a configurable setting which can be on for small wikis and turned off for larger ones when that ceases to be a concern.
As long as it can be either turned off or on to individualize it for the needs of a wiki, I think it is a good change indeed!
I think this proposed feature needs more discussion, preferably in a public forum rather than a developer back channel. A change like this definitely needs community consultation.
Assigning the unblockself right to sysops by default would be an acceptable solution pending community consultation I think.
Never added to core user rights list, added in r89293