MediaWiki r58364 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r58363‎ | r58364 (on ViewVC)‎ | r58365 >
Date:16:19, 30 October 2009
Author:greg
Status:ok (Comments)
Tags:
Comment:
Fix groupby issue in SpecialActiveusers
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialActiveusers.php
===================================================================
--- trunk/phase3/includes/specials/SpecialActiveusers.php	(revision 58363)
+++ trunk/phase3/includes/specials/SpecialActiveusers.php	(revision 58364)
@@ -65,7 +65,7 @@
 				'MAX(ipb_user) AS blocked'
 			),
 			'options' => array(
-				'GROUP BY' => 'rc_user_text',
+				'GROUP BY' => $dbr->implicitGroupby() ? 'rc_user_text' : 'rc_user_text, user_id',
 				'USE INDEX' => array( 'recentchanges' => 'rc_user_text' )
 			),
 			'join_conds' => array(
Index: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES	(revision 58363)
+++ trunk/phase3/RELEASE-NOTES	(revision 58364)
@@ -610,6 +610,7 @@
 * The error message shown in Special:ChangePassword now parses wiki markup
 * (bug 19859) Removed experimental HTMLDiff feature
 * Removed section edit links in edit conflict form
+* Allow SpecialActiveusers to work on non-MySQL databases
 
 == API changes in 1.16 ==
 

Follow-up revisions

Rev.Commit summaryAuthorDate
r62208Fix for r56885, r58364, r58364: use a two-part GROUP BY even on MySQL. The im...tstarling00:41, 10 February 2010

Comments

#Comment by MaxSem (Talk | contribs)   19:08, 5 November 2009

Broke it for SQLite: "aggregate functions are not allowed in the GROUP BY clause"

#Comment by MaxSem (Talk | contribs)   16:31, 11 November 2009

Resolved the above issue in r58915

Status & tagging log

  • 04:09, 5 January 2010 Tim Starling (Talk | contribs) changed the status of r58364 [removed: new added: ok]
  • 16:31, 11 November 2009 MaxSem (Talk | contribs) changed the status of r58364 [removed: fixme added: new]
  • 20:43, 5 November 2009 MaxSem (Talk | contribs) changed the status of r58364 [removed: new added: fixme]
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox