MediaWiki r58362 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r58361‎ | r58362 (on ViewVC)‎ | r58363 >
Date:14:30, 30 October 2009
Author:catrope
Status:ok (Comments)
Tags:
Comment:
Remove section edit links in edit conflict form pointing nowhere useful and only confusing people. Apparently this is a regression from r8855 (!) that went unnoticed for nearly 4.5 years. Hereby nominated for the Most Hilarious Bugs of All Time contest
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r92703(bug 25355) Parser generates edit section links for special pages...demon22:32, 20 July 2011

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r8855* (bug 1989) Some messages converted to use addWikiText(), patch by Niklas La...avar02:05, 4 May 2005

Comments

#Comment by Tim Starling (talk | contribs)   04:07, 5 January 2010

Awesome. Presumably the edit section option should be off for all messages parsed by $wgOut, it seems to be on by default. Article has its own ParserOptions with edit section set explicitly to true, so it won't affect the main content text.

#Comment by Catrope (talk | contribs)   17:04, 5 January 2010

That would make sense, yes. However, I'm personally hesitant to do this, who knows if someone somewhere actually relies on this behavior.

Status & tagging log