MediaWiki r58192 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r58191‎ | r58192 (on ViewVC)‎ | r58193 >
Date:14:08, 27 October 2009
Author:raymond
Status:resolved (Comments)
Tags:
Comment:
New hook getOtherBlockLogLink, called in Special:IPBlockList to show links to block logs of other blocking extensions, i.e. GlobalBlocking
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r58193Use the new hook from r58192: Create a link to the GlobalBlockLograymond14:10, 27 October 2009
r58199Use the new hook from r58192: Creates a "is blocked as a Tor exit node" messa...raymond16:28, 27 October 2009
r58323Follow-up r58192: Improved version. Split info for local and other blocks. Se...raymond16:37, 29 October 2009
r60494Rename hook per Tim's CR on r58192raymond08:51, 30 December 2009

Comments

#Comment by Tim Starling (talk | contribs)   07:01, 30 December 2009

Hook names conventionally start with a capital letter, and omit the verb, because there is a little-known feature in Hooks.php which adds "on" to the start of the hook name to make a method name. This hook should be called "OtherBlockLogLink". Also in the documentation, the parameter should be given a more sensible name, like $ip, rather than $this->ip.

The screenshot on r58323 looks nice.

#Comment by Raymond (talk | contribs)   08:53, 30 December 2009

Thanks for CR.

  • Hook renamed in r60494
  • Hook doc already changed by Ialex in r59182

Status & tagging log