MediaWiki r56817 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r56816‎ | r56817 (on ViewVC)‎ | r56818 >
Date:14:13, 23 September 2009
Author:btongminh
Status:ok (Comments)
Tags:
Comment:
(bug 20780) Fix in UploadBase::detectScript: should check for '<a href', not '<a'. The question remains on whether detectScript is redundant to IEContentAnalyzer.
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r56835Merge r56817 from trunk -- (bug 20780) Fix in UploadBase::detectScript: shoul...brion20:43, 23 September 2009

Comments

#Comment by ^demon (talk | contribs)   14:15, 23 September 2009

What if <a> doesn't begin with href?

#Comment by Bryan (talk | contribs)   14:18, 23 September 2009

Then IE doesn't fuck up apparently.

#Comment by Catrope (talk | contribs)   14:18, 23 September 2009

The objective is to emulate IE's broken algorithm, which also overlooks this. See also bug 20780 comment #3 and below.

#Comment by ^demon (talk | contribs)   14:30, 23 September 2009

Ah ok, I hadn't read the bug. I knew I was stupid and used the precense of <a href as the trigger, didn't know it was so stupid as to only work in that order.

#Comment by ^demon (talk | contribs)   14:31, 23 September 2009

I was stupid -> it was stupid

Status & tagging log

  • 01:08, 18 January 2012 Siebrand (talk | contribs) changed the tags for r56817 [removed: wmf-deployment]
  • 20:43, 23 September 2009 Brion VIBBER (talk | contribs) changed the tags for r56817 [removed: mergeme added: wmf-deployment]
  • 20:43, 23 September 2009 Brion VIBBER (talk | contribs) changed the status of r56817 [removed: new added: ok]
  • 14:17, 23 September 2009 Catrope (talk | contribs) changed the tags for r56817 [added: mergeme]