MediaWiki r56601 - Code Review

Repository:	MediaWiki
Revision:	< r56600‎ \| r56601 (on ViewVC)‎ \| r56602 >
Date:	14:19, 18 September 2009
Author:	simetrical
Status:	ok
Tags:
Comment:	Don't drop default attrib values in non-HTML5 Some attributes that have defaults in HTML5 don't have defaults in XHTML1, particularly type="" on scripts and styles (bug 20713). There's not much point in trying to maintain two separate sets of defaults, so I've just kept the HTML5 ones and haven't tried to strip any defaults in XHTML1 mode.
Modified paths:	/trunk/phase3/includes/Html.php (modified) (history) (diff)

Diff [purge]

Index: trunk/phase3/includes/Html.php
—	—	@@ -195,6 +195,13 @@
196	196	* @return array An array of attributes functionally identical to $attribs
197	197	*/
198	198	private static function dropDefaults( $element, $attribs ) {
	199	+ # Don't bother doing anything if we aren't outputting HTML5; it's too
	200	+ # much of a pain to maintain two sets of defaults.
	201	+ global $wgHtml5;
	202	+ if ( !$wgHtml5 ) {
	203	+ return $attribs;
	204	+ }
	205	+
199	206	static $attribDefaults = array(
200	207	'area' => array( 'shape' => 'rect' ),
201	208	'button' => array(

Rev.	Commit summary	Author	Date
r56725	Merge trunk r56601: Don't drop default attrib values in non-HTML5 (bug 20713)	brion	18:29, 21 September 2009

01:08, 18 January 2012 Siebrand (Talk | contribs) changed the tags for r56601 [removed: wmf-deployment]
23:02, 29 September 2009 Brion VIBBER (Talk | contribs) changed the status of r56601 [removed: new added: ok]
18:29, 21 September 2009 Brion VIBBER (Talk | contribs) changed the tags for r56601 [added: wmf-deployment]