MediaWiki r56068 - Code Review

Index: trunk/phase3/includes/Linker.php
===================================================================
--- trunk/phase3/includes/Linker.php	(revision 56067)
+++ trunk/phase3/includes/Linker.php	(revision 56068)
@@ -1941,8 +1941,8 @@
 	 * @deprecated Returns raw bits of HTML, use titleAttrib() and accesskey()
 	 */
 	public function tooltipAndAccesskey( $name ) {
-		global $wgDisableTooltipsAndAccesskeys;
-		if ($wgDisableTooltipsAndAccesskeys)
+		global $wgEnableTooltipsAndAccesskeys;
+		if (!$wgEnableTooltipsAndAccesskeys)
 			return array();
 		# FIXME: If Sanitizer::expandAttributes() treated "false" as "output
 		# no attribute" instead of "output '' as value for attribute", this
@@ -1962,8 +1962,8 @@
 
 	/** @deprecated Returns raw bits of HTML, use titleAttrib() */
 	public function tooltip( $name, $options = null ) {
-		global $wgDisableTooltipsAndAccesskeys;
-		if ($wgDisableTooltipsAndAccesskeys)
+		global $wgEnableTooltipsAndAccesskeys;
+		if ($wgEnableTooltipsAndAccesskeys)
 			return array();
 		# FIXME: If Sanitizer::expandAttributes() treated "false" as "output
 		# no attribute" instead of "output '' as value for attribute", this
Index: trunk/phase3/includes/DefaultSettings.php
===================================================================
--- trunk/phase3/includes/DefaultSettings.php	(revision 56067)
+++ trunk/phase3/includes/DefaultSettings.php	(revision 56068)
@@ -3464,9 +3464,11 @@
 $wgDisableHardRedirects = false;
 
 /**
- * Disable tooltips and access keys
+ * Set to false to disable application of access keys and tooltips,
+ * eg to avoid keyboard conflicts with system keys or as a low-level
+ * optimization.
  */
-$wgDisableTooltipsAndAccesskeys = false;
+$wgEnableTooltipsAndAccesskeys = true;
 
 /**
  * Use http.dnsbl.sorbs.net to check for open proxies