MediaWiki r55558 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r55557‎ | r55558 (on ViewVC)‎ | r55559 >
Date:18:06, 24 August 2009
Author:ialex
Status:ok (Comments)
Tags:todo 
Comment:
* (bug 19966) MediaWiki:License-header is now used for the licensing header in the file description page instead of MediaWiki:License
I've copied the 'license' message to 'license-header' for all languages, will fuzzy them on translatewiki.net so that they'll be corrected
Modified paths:

Follow-up revisions

Rev.Commit summaryAuthorDate
r55559revert wrong change from r55558ialex18:28, 24 August 2009

Comments

#Comment by Mormegil (talk | contribs)   12:49, 25 August 2009

This is an unfortunate solution from the Commons’ view. There is a great number of pages using Licensing: as the section caption… (which should now be changed to Licensing). The other way round (keeping “license” for the section caption, and introducing e.g. “license-label”) would be much more friendly to Commons.

#Comment by IAlex (talk | contribs)   15:26, 25 August 2009

I changed it to MediaWiki:License-header and not MediaWiki:License-label since MediaWiki:License is already defined with the colon for the label so MediaWiki:License doesn't have to be changed, which would not have been the case if MediaWiki:License-label was added.

#Comment by Mormegil (talk | contribs)   16:07, 25 August 2009

Just to clarify, because of the formatting. Commons pages use {{int:licensing}} (to ensure proper localization).

#Comment by Brion VIBBER (talk | contribs)   17:59, 26 August 2009

If they use {{int:licensing}} then they will not be affected by a change to the 'license' message. Can you clarify and provide some sample links? Thanks!

#Comment by Mormegil (talk | contribs)   20:05, 26 August 2009

D’oh! Trying twice, and getting it wrong both times, me stupid! OK, for the third time, now hopefully correct:

On Commons, the caption of the licensing section on a file description page is usually changed to “== {{int:license}} ==” (see e.g. [1]), so that it gets translated correctly (and the top section is changed to “== {{int:filedesc}} ==” for the same reason). If the section header will now be under {{int:license-header}} instead of that {{int:license}}, we will have to change all those (well, not really, keeping them under int:license is not a catastrophic problem, but still…).

#Comment by Brion VIBBER (talk | contribs)   19:02, 10 September 2009

I'm going to mark this OK for now... it sounds like it won't really make the situation any worse than it already is. :)

The whole lot needs a cleanup at some point though (eg it should actually *get initially saved* to the standard format, not need changing later), so marking this as todo.

Status & tagging log