r55189 - Code Review

From MediaWiki.org

Jump to: navigation, search
Repository:MediaWiki
Revision:r55188 | r55189 (on ViewVC) | r55190 >
Date:15:46, 17 August 2009
Author:werdna
Status:new
Tags:
Comment:Fix bug 20095, update id/username storage when users are renamed
Modified paths:

Diff [purge]

Index: trunk/extensions/Renameuser/SpecialRenameuser_body.php
===================================================================
--- trunk/extensions/Renameuser/SpecialRenameuser_body.php	(revision 55188)
+++ trunk/extensions/Renameuser/SpecialRenameuser_body.php	(revision 55189)
@@ -397,6 +397,8 @@
 		} else {
 			$this->tables['recentchanges'] = array('rc_user_text','rc_user');
 		}
+		
+		wfRunHooks( 'RenameUserSQL', array( $this ) );
 	}
 
 	/**
Index: trunk/extensions/LiquidThreads/LiquidThreads.php
===================================================================
--- trunk/extensions/LiquidThreads/LiquidThreads.php	(revision 55188)
+++ trunk/extensions/LiquidThreads/LiquidThreads.php	(revision 55189)
@@ -77,6 +77,9 @@
 // Search
 $wgHooks['ShowSearchHitTitle'][] = 'LqtHooks::customiseSearchResultTitle';
 
+// Rename
+$wgHooks['RenameUserSQL'][] = 'LqtHooks::onUserRename';
+
 // Special pages
 $wgSpecialPages['MoveThread'] = 'SpecialMoveThread';
 $wgSpecialPages['NewMessages'] = 'SpecialNewMessages';
Index: trunk/extensions/LiquidThreads/classes/Hooks.php
===================================================================
--- trunk/extensions/LiquidThreads/classes/Hooks.php	(revision 55188)
+++ trunk/extensions/LiquidThreads/classes/Hooks.php	(revision 55189)
@@ -240,4 +240,13 @@
 		
 		return true;
 	}
+	
+	static function onUserRename( $renameUserSQL ) {
+		// Always use the job queue, talk page edits will take forever
+		$renameUserSQL->tablesJob['thread'] =
+				array( 'thread_author_name', 'thread_author_id', 'thread_modified' );
+		$renameUserSQL->tablesJob['thread_history'] =
+				array( 'th_user_text', 'th_user', 'th_timestamp' );
+		return true;
+	}
 }
Index: trunk/extensions/LiquidThreads/lqt.sql
===================================================================
--- trunk/extensions/LiquidThreads/lqt.sql	(revision 55188)
+++ trunk/extensions/LiquidThreads/lqt.sql	(revision 55189)
@@ -25,7 +25,8 @@
   INDEX thread_article_title (thread_article_namespace, thread_article_title),
   INDEX thread_modified (thread_modified),
   INDEX thread_created (thread_created),
-  INDEX thread_summary_page (thread_summary_page)
+  INDEX thread_summary_page (thread_summary_page),
+  INDEX (thread_author_id,thread_author_name)
 ) /*$wgDBTableOptions*/;
 
 
Views
Toolbox