MediaWiki r54312 - Code Review

Repository:	MediaWiki
Revision:	< r54311‎ \| r54312 (on ViewVC)‎ \| r54313 >
Date:	21:56, 3 August 2009
Author:	demon
Status:	ok
Tags:
Comment:	Revert r54244 which was stupid and fix this properly. Require commandLine.inc/Maintenance.php using the full path every time.
Modified paths:	/trunk/phase3/RELEASE-NOTES (modified) (history) (diff) /trunk/phase3/maintenance/addwiki.php (modified) (history) (diff) /trunk/phase3/maintenance/attachLatest.php (modified) (history) (diff) /trunk/phase3/maintenance/benchmarkPurge.php (modified) (history) (diff) /trunk/phase3/maintenance/cdb-test.php (modified) (history) (diff) /trunk/phase3/maintenance/changePassword.php (modified) (history) (diff) /trunk/phase3/maintenance/checkAutoLoader.php (modified) (history) (diff) /trunk/phase3/maintenance/checkBadRedirects.php (modified) (history) (diff) /trunk/phase3/maintenance/checkImages.php (modified) (history) (diff) /trunk/phase3/maintenance/checkUsernames.php (modified) (history) (diff) /trunk/phase3/maintenance/cleanupCaps.php (modified) (history) (diff) /trunk/phase3/maintenance/cleanupImages.php (modified) (history) (diff) /trunk/phase3/maintenance/cleanupSpam.php (modified) (history) (diff) /trunk/phase3/maintenance/cleanupTitles.php (modified) (history) (diff) /trunk/phase3/maintenance/cleanupWatchlist.php (modified) (history) (diff) /trunk/phase3/maintenance/clear_interwiki_cache.php (modified) (history) (diff) /trunk/phase3/maintenance/clear_stats.php (modified) (history) (diff) /trunk/phase3/maintenance/convertLinks.php (modified) (history) (diff) /trunk/phase3/maintenance/convertUserOptions.php (modified) (history) (diff) /trunk/phase3/maintenance/createAndPromote.php (modified) (history) (diff) /trunk/phase3/maintenance/deleteArchivedFiles.php (modified) (history) (diff) /trunk/phase3/maintenance/deleteArchivedRevisions.php (modified) (history) (diff) /trunk/phase3/maintenance/deleteBatch.php (modified) (history) (diff) /trunk/phase3/maintenance/deleteDefaultMessages.php (modified) (history) (diff) /trunk/phase3/maintenance/deleteImageMemcached.php (modified) (history) (diff) /trunk/phase3/maintenance/deleteOldRevisions.php (modified) (history) (diff) /trunk/phase3/maintenance/deleteOrphanedRevisions.php (modified) (history) (diff) /trunk/phase3/maintenance/deleteRevision.php (modified) (history) (diff) /trunk/phase3/maintenance/dumpBackup.php (modified) (history) (diff) /trunk/phase3/maintenance/dumpInterwiki.php (modified) (history) (diff) /trunk/phase3/maintenance/dumpLinks.php (modified) (history) (diff) /trunk/phase3/maintenance/dumpSisterSites.php (modified) (history) (diff) /trunk/phase3/maintenance/dumpTextPass.php (modified) (history) (diff) /trunk/phase3/maintenance/dumpUploads.php (modified) (history) (diff) /trunk/phase3/maintenance/edit.php (modified) (history) (diff) /trunk/phase3/maintenance/eval.php (modified) (history) (diff) /trunk/phase3/maintenance/fetchText.php (modified) (history) (diff) /trunk/phase3/maintenance/findhooks.php (modified) (history) (diff) /trunk/phase3/maintenance/fixSlaveDesync.php (modified) (history) (diff) /trunk/phase3/maintenance/fixTimestamps.php (modified) (history) (diff) /trunk/phase3/maintenance/fixUserRegistration.php (modified) (history) (diff) /trunk/phase3/maintenance/fuzz-tester.php (modified) (history) (diff) /trunk/phase3/maintenance/generateSitemap.php (modified) (history) (diff) /trunk/phase3/maintenance/getLagTimes.php (modified) (history) (diff) /trunk/phase3/maintenance/getSlaveServer.php (modified) (history) (diff) /trunk/phase3/maintenance/http_session_download.php (modified) (history) (diff) /trunk/phase3/maintenance/importDump.php (modified) (history) (diff) /trunk/phase3/maintenance/importImages.php (modified) (history) (diff) /trunk/phase3/maintenance/importTextFile.php (modified) (history) (diff) /trunk/phase3/maintenance/initEditCount.php (modified) (history) (diff) /trunk/phase3/maintenance/initStats.php (modified) (history) (diff) /trunk/phase3/maintenance/installExtension.php (modified) (history) (diff) /trunk/phase3/maintenance/mcc.php (modified) (history) (diff) /trunk/phase3/maintenance/mctest.php (modified) (history) (diff) /trunk/phase3/maintenance/moveBatch.php (modified) (history) (diff) /trunk/phase3/maintenance/namespaceDupes.php (modified) (history) (diff) /trunk/phase3/maintenance/nextJobDB.php (modified) (history) (diff) /trunk/phase3/maintenance/nukeNS.php (modified) (history) (diff) /trunk/phase3/maintenance/nukePage.php (modified) (history) (diff) /trunk/phase3/maintenance/orphans.php (modified) (history) (diff) /trunk/phase3/maintenance/parserTests.inc (modified) (history) (diff) /trunk/phase3/maintenance/patchSql.php (modified) (history) (diff) /trunk/phase3/maintenance/populateCategory.php (modified) (history) (diff) /trunk/phase3/maintenance/populateLogSearch.php (modified) (history) (diff) /trunk/phase3/maintenance/populateLogUsertext.php (modified) (history) (diff) /trunk/phase3/maintenance/populateParentId.php (modified) (history) (diff) /trunk/phase3/maintenance/preprocessorFuzzTest.php (modified) (history) (diff) /trunk/phase3/maintenance/protect.php (modified) (history) (diff) /trunk/phase3/maintenance/purgeList.php (modified) (history) (diff) /trunk/phase3/maintenance/purgeOldText.php (modified) (history) (diff) /trunk/phase3/maintenance/reassignEdits.php (modified) (history) (diff) /trunk/phase3/maintenance/rebuildFileCache.php (modified) (history) (diff) /trunk/phase3/maintenance/rebuildImages.php (modified) (history) (diff) /trunk/phase3/maintenance/rebuildInterwiki.php (modified) (history) (diff) /trunk/phase3/maintenance/rebuildLocalisationCache.php (modified) (history) (diff) /trunk/phase3/maintenance/rebuildall.php (modified) (history) (diff) /trunk/phase3/maintenance/rebuildmessages.php (modified) (history) (diff) /trunk/phase3/maintenance/rebuildrecentchanges.php (modified) (history) (diff) /trunk/phase3/maintenance/rebuildtextindex.php (modified) (history) (diff) /trunk/phase3/maintenance/refreshImageCount.php (modified) (history) (diff) /trunk/phase3/maintenance/refreshLinks.php (modified) (history) (diff) /trunk/phase3/maintenance/removeUnusedAccounts.php (modified) (history) (diff) /trunk/phase3/maintenance/renameDbPrefix.php (modified) (history) (diff) /trunk/phase3/maintenance/renamewiki.php (modified) (history) (diff) /trunk/phase3/maintenance/renderDump.php (modified) (history) (diff) /trunk/phase3/maintenance/runJobs.php (modified) (history) (diff) /trunk/phase3/maintenance/showJobs.php (modified) (history) (diff) /trunk/phase3/maintenance/showStats.php (modified) (history) (diff) /trunk/phase3/maintenance/sql.php (modified) (history) (diff) /trunk/phase3/maintenance/stats.php (modified) (history) (diff) /trunk/phase3/maintenance/undelete.php (modified) (history) (diff) /trunk/phase3/maintenance/update.php (modified) (history) (diff) /trunk/phase3/maintenance/updateArticleCount.php (modified) (history) (diff) /trunk/phase3/maintenance/updateRestrictions.php (modified) (history) (diff) /trunk/phase3/maintenance/updateSearchIndex.php (modified) (history) (diff) /trunk/phase3/maintenance/updateSpecialPages.php (modified) (history) (diff) /trunk/phase3/maintenance/upgrade1_5.php (modified) (history) (diff) /trunk/phase3/maintenance/userOptions.inc (modified) (history) (diff) /trunk/phase3/maintenance/waitForSlave.php (modified) (history) (diff)

Follow-up revisions

Rev.	Commit summary	Author	Date
r54839	Revert eval.php changes from r54653, r54312, r54225 (maintenance-work branch ...	tstarling	03:44, 12 August 2009

Past revisions this follows-up on

Rev.	Commit summary	Author	Date
r54244	(bug 18855) Consistently call commandLine.inc with how we more or less do it ...	demon	22:55, 2 August 2009

Status & tagging log

00:01, 5 August 2009 Brion VIBBER (Talk | contribs) changed the status of r54312 [removed: new added: ok]

MediaWiki r54312 - Code Review

Follow-up revisions

Past revisions this follows-up on

Status & tagging log

Personal tools

Namespaces

Variants

Views

Actions

Search

Navigation

Support

Download

Development

Communication

Toolbox