MediaWiki r54242 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r54241‎ | r54242 (on ViewVC)‎ | r54243 >
Date:22:15, 2 August 2009
Author:simetrical
Status:resolved (Comments)
Tags:
Comment:
Add legend and tooltips to explain RC flags

Based on a patch submitted by svip on IRC. I also changed the <span>
for unpatrolled into an <abbr>, and created a new message in case anyone
wants to localize !, for the sake of uniformity.
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r54248Add legend to watchlist as well...simetrical00:21, 3 August 2009
r54258Make work with core r54242nikerabbit09:14, 3 August 2009
r54335Show change flag tooltips everywhere, not just RC...simetrical00:28, 4 August 2009
r54336Only show useful info in RC legend...simetrical00:48, 4 August 2009
r54337Add wrapper div for RC label legend...simetrical00:50, 4 August 2009

Comments

#Comment by Nikerabbit (talk | contribs)   09:14, 3 August 2009

I don't quite like the redundancy (legend + tooltips). Recent changes is already quite big in terms of html source code.

#Comment by Svippong (talk | contribs)   14:40, 3 August 2009

I think the redundancy in this case makes sense. The legend is pretty much required. The tooltips is to describe the flags where they are. When it comes to usability, redundancy is usually better. Especially having both a legend and tooltips.

True, the legend is much less HTML than each tooltip will make up to be. But they serve a common purpose.

#Comment by Simetrical (talk | contribs)   16:59, 3 August 2009

Well, at least the legend is necessary, because currently there's no explanation at all. The tooltips I'm not as attached to, but I agree with svip that redundancy is good for usability. RC is big because it has lots of content!

#Comment by Umherirrender (talk | contribs)   16:23, 3 August 2009

Please wrap 'recentchanges-label-legend' into a div with id. Then users can add own style. Thanks.

#Comment by Simetrical (talk | contribs)   00:51, 4 August 2009

Done in r54337. I used a class instead of id because classes are more flexible; we don't necessarily want to restrict ourselves to having only one of these. (For instance, some skin might want to put another one on the bottom of the page.)

#Comment by Umherirrender (talk | contribs)   17:29, 3 August 2009

Missing tooltip for Diffs and Contributions, see r53975 for all places where the span was changed to abbr.

#Comment by Simetrical (talk | contribs)   00:28, 4 August 2009

Thanks for the pointer, fixed in r54335.

#Comment by Brion VIBBER (talk | contribs)   22:26, 4 August 2009

We've lived without a legend for years, and of course note that it's not visible unless you're scrolled to the top anyway. :)

IMO the legend is also just not very attractive... the formatting looks very odd and it doesn't feel in place on the page.

#Comment by Simetrical (talk | contribs)   00:07, 5 August 2009

But currently there's no way for users to figure out what the flags actually mean. Do you think the tooltips are sufficient? I guess the meaning isn't really important for most users, so maybe having the info only in tooltips is acceptable.

#Comment by Werdna (talk | contribs)   17:01, 27 August 2009

Fixed up in later revisions.

Status & tagging log

  • 17:01, 27 August 2009 Werdna (talk | contribs) changed the status of r54242 [removed: fixme added: resolved]
  • 22:26, 4 August 2009 Brion VIBBER (talk | contribs) changed the status of r54242 [removed: new added: fixme]