MediaWiki r51889 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r51888‎ | r51889 (on ViewVC)‎ | r51890 >
Date:12:12, 15 June 2009
Author:siebrand
Status:ok
Tags:
Comment:
(bug 19205 ) Follow-up to 50351 and 51572: no double escaping.
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialUndelete.php
===================================================================
--- trunk/phase3/includes/specials/SpecialUndelete.php	(revision 51888)
+++ trunk/phase3/includes/specials/SpecialUndelete.php	(revision 51889)
@@ -681,7 +681,7 @@
 				$undelete,
 				htmlspecialchars( $title->getPrefixedText() ),
 				array(),
-				array( 'target' => $title->getPrefixedUrl() )
+				array( 'target' => $title->getPrefixedText() )
 			);
 			$revs = wfMsgExt( 'undeleterevisions',
 				array( 'parseinline' ),
@@ -841,7 +841,7 @@
 			/// @fixme $rev->getTitle() is null for deleted revs...?
 			$targetPage = SpecialPage::getTitleFor( 'Undelete' );
 			$targetQuery = array(
-				'target' => $this->mTargetObj->getPrefixedUrl(),
+				'target' => $this->mTargetObj->getPrefixedText(),
 				'timestamp' => wfTimestamp( TS_MW, $rev->getTimestamp() )
 			);
 		} else {
@@ -1120,7 +1120,7 @@
 					wfMsgHtml('diff'),
 					array(),
 					array(
-						'target' => $this->mTargetObj->getPrefixedUrl(),
+						'target' => $this->mTargetObj->getPrefixedText(),
 						'timestamp' => $ts,
 						'diff' => 'prev'
 					)
@@ -1218,7 +1218,7 @@
 				$time,
 				array(),
 				array(
-					'target' => $this->mTargetObj->getPrefixedUrl(),
+					'target' => $this->mTargetObj->getPrefixedText(),
 					'timestamp' => $ts
 				)
 			);
@@ -1243,7 +1243,7 @@
 				$wgLang->timeanddate( $ts, true ),
 				array(),
 				array(
-					'target' => $this->mTargetObj->getPrefixedUrl(),
+					'target' => $this->mTargetObj->getPrefixedText(),
 					'file' => $key,
 					'token' => $wgUser->editToken( $key )
 				)

Status & tagging log

Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox