MediaWiki r51297 - Code Review

Index: trunk/extensions/NewUserMessage/NewUserMessage.i18n.php
===================================================================
--- trunk/extensions/NewUserMessage/NewUserMessage.i18n.php	(revision 51296)
+++ trunk/extensions/NewUserMessage/NewUserMessage.i18n.php	(revision 51297)
@@ -13,8 +13,9 @@
 $messages['en'] = array(
 	'newusermessage-desc' => "Adds a message to newly created user's talk pages",
 	'newuseredit-summary' => 'Adding [[{{int:newusermessage-template}}|welcome message]] to new user\'s talk page',
-	'newusermessage-template' => 'Template:Welcome', // The title of the message template
-	'newusermessage-editor' => 'New user message', // The username used for the edit
+	'newusermessage-template' => 'Template:Welcome', # The title of the message template
+	'newusermessage-editor' => 'New user message', # The username used for the edit
+	'newusermessage-substitute' => '', # do not translate or duplicate this message to other languages
 );
 
 /** Message documentation (Message documentation)
Index: trunk/extensions/NewUserMessage/NewUserMessage.php
===================================================================
--- trunk/extensions/NewUserMessage/NewUserMessage.php	(revision 51296)
+++ trunk/extensions/NewUserMessage/NewUserMessage.php	(revision 51297)
@@ -12,7 +12,7 @@
 if (!defined('MEDIAWIKI'))
 	die('Not an entry point.');
 
-define('NEWUSERMESSAGE_VERSION','2.1, 2009-01-07');
+define('NEWUSERMESSAGE_VERSION','2.2, 2009-06-01');
 
 $wgNewUserSuppressRC = false;           // Specify whether or not the new user message creation should show up in recent changes
 $wgNewUserMinorEdit = true;             // Should the new user message creation be a minor edit?
Index: trunk/extensions/NewUserMessage/NewUserMessage.class.php
===================================================================
--- trunk/extensions/NewUserMessage/NewUserMessage.class.php	(revision 51296)
+++ trunk/extensions/NewUserMessage/NewUserMessage.class.php	(revision 51297)
@@ -53,7 +53,13 @@
 			$dbw->begin();
 			$good = true;
 
-			$text = "{{{$templateTitleText}|$name|$realName}}";
+			// Add (any) content to [[MediaWiki:Newusermessage-substitute]] to substitute the welcome template.
+			$substitute = wfMsgForContent( 'newusermessage-substitute' );
+			if ( $substitute ) {
+				$text = "{{subst:{$templateTitleText}|$name|$realName}}";
+			} else {
+				$text = "{{{$templateTitleText}|$name|$realName}}";
+			}
 			$signatures = wfMsgForContent( 'newusermessage-signatures' );
 			if ( !wfEmptyMsg( 'newusermessage-signatures', $signatures ) ) {
 				$pattern = '/^\* ?(.*?)$/m';