MediaWiki r49890 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:< r49889‎ | r49890 (on ViewVC)‎ | r49891 >
Date:05:22, 26 April 2009
Author:shinjiman
Status:deferred (Comments)
Tags:
Comment:
* (bug 18242) Show the Subversion revision number per extensions in Special:Version (currently applied on some extensions to get the entries file)
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r49924Follows up r49890, adding file location itself to obtaining the revision numb...shinjiman03:15, 27 April 2009
r49926Follows up r49890, adding file location itself to obtaining the revision numb...shinjiman03:53, 27 April 2009
r49927Follows up r49890, adding file location itself to obtaining the revision numb...shinjiman04:45, 27 April 2009
r49992Follows up r49890, adding file location itself to obtaining the revision numb...shinjiman02:35, 28 April 2009

Comments

#Comment by Simetrical (Talk | contribs)   19:50, 26 April 2009

Boolean parameters aren't ideal. self::getSvnRevision( $IP, true/false ) is pretty opaque. self::getSvnRevision( $IP, 'extension'/null ) would be much more readable. Also, you should add the new parameter to the getSvnRevision() documentation.

Good solution, though.  :)

Status & tagging log

  • 22:26, 14 November 2009 Bryan (Talk | contribs) changed the status of r49890 [removed: ok added: deferred]
  • 16:17, 26 May 2009 Tim Starling (Talk | contribs) changed the status of r49890 [removed: new added: ok]
  • 19:05, 27 April 2009 Brion VIBBER (Talk | contribs) changed the status of r49890 [removed: new added: ok]
Retrieved from "http://www.mediawiki.org/wiki/Special:Code/MediaWiki/49890"
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox