MediaWiki r49790 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:< r49789‎ | r49790 (on ViewVC)‎ | r49791 >
Date:01:31, 24 April 2009
Author:werdna
Status:resolved (Comments)
Tags:
Comment:
Branch merge of preferences work branch. Includes fixes for several bugs. WARNING: Breaks some extensions which have not been adapted to use it properly (basically anything not used on Wikimedia).
Modified paths:

Follow-up revisions

Rev.Commit summaryAuthorDate
r49803Follow-up r49790: update the PostgreSQL schemaialex08:49, 24 April 2009
r49820Updates preferences handling to work with r49790 and upsiebrand17:16, 24 April 2009
r49825Updates preferences handling to work with r49790 and up. Needs review, as the...siebrand18:06, 24 April 2009
r49826Updates preferences handling to work with r49790 and up. Please review...siebrand18:26, 24 April 2009
r49873Follow-up r49790: remove from docs/hooks.txt hooks that were removed from codeialex13:50, 25 April 2009
r49905Follow up on r49790. Fixed a bug on variant select.philip14:51, 26 April 2009
r49913Follow up on r49790. 'prefsreset' is no longer used.siebrand21:35, 26 April 2009
r49916Follow-up on r49790, r49898, r49899, r49900, r49901, r49902, r49904, r49907, ...siebrand22:00, 26 April 2009
r49932Partial revert of r49790 (global preferences) at Brion's request to ease revi...werdna06:15, 27 April 2009
r49955Fix regression in r49790, weird spacing for Gadgets and Skin tab.werdna14:18, 27 April 2009
r51340Fix fatal error in r49790, remaining usage of User::encodeOptions()werdna12:42, 2 June 2009

Comments

#Comment by Raymond (Talk | contribs)   21:30, 24 April 2009

The skin tab shows link to "(Custom CSS) (Custom JS)" for every skin instead of the currently used skin.

#Comment by Werdna (Talk | contribs)   02:00, 27 April 2009

Doesn't seem to be a regression.

#Comment by Raymond (Talk | contribs)   08:41, 30 April 2009

Sorry, you are right, but I could swear ... *shrugs*

#Comment by Raymond (Talk | contribs)   06:45, 26 April 2009

More FIXMEs:

At the edit tab: missing the message 'prefs-edit-boxsize'

At the watchlist tab: missing the messages 'prefs-watchlist-days-max', 'prefs-watchlist-edits-max'

At the recent changes tab: missing the message 'recentchangesdays-max'

#Comment by Werdna (Talk | contribs)   01:41, 27 April 2009

I don't understand this comment.

#Comment by ^demon (Talk | contribs)   14:37, 27 April 2009

The watchlist and RC tabs seem to be ok. However, on the edit tab, there's no indication of what "rows" and "columns" means.

#Comment by Raymond (Talk | contribs)   10:07, 30 April 2009

I mean the red bordered messages. These are indications to the user for the maximum allowed values.

Preferences - watchlist
Preferences - recent changes
#Comment by Siebrand (Talk | contribs)   12:37, 26 April 2009

bugzilla:18595: Quickbar has disappeared in Cologneblue and Standard skins

#Comment by Siebrand (Talk | contribs)   12:38, 26 April 2009

bugzilla:18580: New preferences page does not contain e-mail confirmation data

#Comment by Siebrand (Talk | contribs)   12:38, 26 April 2009

bugzilla:18581: Enable e-mail from other users setting not displayed correctly

#Comment by Siebrand (Talk | contribs)   21:41, 26 April 2009

bugzilla:18603 Link to Special:ChangePassword has disappeared from Special:Preferences tab User Profile

#Comment by Werdna (Talk | contribs)   00:26, 27 April 2009

WFM

#Comment by Werdna (Talk | contribs)   02:17, 27 April 2009

All reported bugs fixed, except as noted above. Please report any other regressions or bugs.

#Comment by Werdna (Talk | contribs)   06:08, 27 April 2009

TODO for discussion with Brion:

1/ Weird spacing on gadgets and skin 2/ Renaming properties to options 3/ Warning about changing mail 4/ Investigate centralauth not being able to save email 5/ we now have too many tabs, re-merge them (email status and options are no longer visible on same screen as email; need to be re-combined)

#Comment by Werdna (Talk | contribs)   14:11, 27 April 2009

3, 4 and 5 fixed. Still need to look at 1 and 2.

#Comment by Werdna (Talk | contribs)   14:38, 27 April 2009

Everything done except the rename. Remaining references to 'properties' are the DB tables, seems like a bad idea to rename them considering this will be live on some sites now. (Although it can probably be done with DB updates if it's really necessary)

#Comment by Werdna (Talk | contribs)   06:17, 27 April 2009

06:25 < wikibugs> (NEW) Image and thumbsize reset to defaults in the new preferences - https://bugzilla.wikimedia.org/show_bug.cgi?id=18605 minor; Normal; MediaWiki: User preferences; 

                 (niklas.laxstrom)
#Comment by Werdna (Talk | contribs)   23:46, 27 April 2009
  • Reports that the email confirmation thing is coming up all the time.
  • Sectionise
  • Gray out email options
#Comment by Werdna (Talk | contribs)   04:20, 30 April 2009

Nothing pending on this, please let me know if there is.

#Comment by Aaron Schulz (Talk | contribs)   05:00, 30 May 2009

$user->encodeOptions() used but doesn't exist

#Comment by Werdna (Talk | contribs)   12:43, 2 June 2009

That should be fixed in r51340.

#Comment by Shinjiman (Talk | contribs)   16:09, 3 June 2009

And more fixmes:

  • bug 18870: The toggle defined in $extraUserToggles won't display in the user preferences
#Comment by ^demon (Talk | contribs)   07:44, 8 February 2011

Preferences rewrite has been deployed for a long time :)

Status & tagging log

  • 09:07, 18 January 2012 Siebrand (Talk | contribs) changed the tags for r49790 [removed: schema]
  • 07:44, 8 February 2011 ^demon (Talk | contribs) changed the tags for r49790 [removed: scaptrap]
  • 04:57, 6 June 2009 Tim Starling (Talk | contribs) changed the tags for r49790 [added: scaptrap]
  • 05:47, 4 June 2009 Tim Starling (Talk | contribs) changed the status of r49790 [removed: fixme added: resolved]
  • 07:24, 22 May 2009 Tim Starling (Talk | contribs) changed the tags for r49790 [added: schema]
  • 10:07, 30 April 2009 Raymond (Talk | contribs) changed the status of r49790 [removed: new added: fixme]
  • 04:20, 30 April 2009 Werdna (Talk | contribs) changed the status of r49790 [removed: fixme added: new]
  • 14:07, 27 April 2009 Werdna (Talk | contribs) changed the status of r49790 [removed: new added: fixme]
  • 04:51, 27 April 2009 Werdna (Talk | contribs) changed the status of r49790 [removed: fixme added: new]
  • 21:30, 24 April 2009 Raymond (Talk | contribs) changed the status of r49790 [removed: new added: fixme]
Retrieved from "http://www.mediawiki.org/wiki/Special:Code/MediaWiki/49790"
Personal tools
Namespaces

Variants
Views
Actions
Navigation
Support
Download
Development
Communication
Toolbox