r49758 - Code Review

From MediaWiki.org

Jump to: navigation, search
Repository:MediaWiki
Revision:r49757 | r49758 (on ViewVC) | r49759 >
Date:04:30, 23 April 2009
Author:werdna
Status:ok
Tags:
Comment:Allow filtering by page on AbuseFilter batch testing interface
Modified paths:

Diff [purge]

Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewTestBatch.php
===================================================================
--- trunk/extensions/AbuseFilter/Views/AbuseFilterViewTestBatch.php	(revision 49757)
+++ trunk/extensions/AbuseFilter/Views/AbuseFilterViewTestBatch.php	(revision 49758)
@@ -43,7 +43,6 @@
 			);
 		$output = Xml::tags( 'div', array( 'id' => 'mw-abusefilter-test-editor' ), $output );
 
-		// Removed until I can distinguish between positives and negatives :)
  		$output .= Xml::tags( 'p', null, Xml::checkLabel( wfMsg( 'abusefilter-test-shownegative' ), 'wpShowNegative', 'wpShowNegative', $this->mShowNegative ) );
 
 		// Selectory stuff
@@ -53,6 +52,9 @@
 			Xml::input( 'wpTestPeriodStart', 45, $this->mTestPeriodStart );
 		$selectFields['abusefilter-test-period-end'] = 
 			Xml::input( 'wpTestPeriodEnd', 45, $this->mTestPeriodEnd );
+		$selectFields['abusefilter-test-page'] =
+			Xml::input( 'wpTestPage', 45, $this->mTestPage );
+			
 		$output .= Xml::buildForm( $selectFields, 'abusefilter-test-submit' );
 		
 		$output .= Xml::hidden( 'title', $this->getTitle("test")->getPrefixedText() );
@@ -91,6 +93,11 @@
 			$conds[] = 'rc_timestamp <= ' . 
 				$dbr->addQuotes( $dbr->timestamp( strtotime( $this->mTestPeriodEnd ) ) );
 		}
+		if ($this->mTestPage) {
+			$title = Title::newFromText( $this->mTestPage );
+			$conds['rc_namespace'] = $title->getNamespace();
+			$conds['rc_title'] = $title->getDBKey();
+		}
 
 		// Get our ChangesList
 		$changesList = new AbuseFilterChangesList( $wgUser->getSkin() );
@@ -132,6 +139,7 @@
 		$testUsername = $wgRequest->getText( 'wpTestUser' );
 		$this->mTestPeriodEnd = $wgRequest->getText( 'wpTestPeriodEnd' );
 		$this->mTestPeriodStart = $wgRequest->getText( 'wpTestPeriodStart' );
+		$this->mTestPage = $wgRequest->getText( 'wpTestPage' );
 
 		if ( !$this->mFilter 
 			&& count($this->mParams) > 1 
Index: trunk/extensions/AbuseFilter/AbuseFilter.i18n.php
===================================================================
--- trunk/extensions/AbuseFilter/AbuseFilter.i18n.php	(revision 49757)
+++ trunk/extensions/AbuseFilter/AbuseFilter.i18n.php	(revision 49758)
@@ -382,6 +382,7 @@
 	'abusefilter-test-user' => 'Changes by user:',
 	'abusefilter-test-period-start' => 'Changes made after:',
 	'abusefilter-test-period-end' => 'Changes made before:',
+	'abusefilter-test-page' => 'Changes made to page:',
 	'abusefilter-test-shownegative' => 'Show changes that do not match the filter',
 	'abusefilter-test-syntaxerr' => 'The filter you entered contained a syntax error.
 You can receive a full explanation by clicking the "Check Syntax" button.',

Status & tagging log

Views
Toolbox