MediaWiki r49575 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r49574‎ | r49575 (on ViewVC)‎ | r49576 >
Date:21:46, 16 April 2009
Author:catrope
Status:reverted (Comments)
Tags:
Comment:
(bug 6092) Add parser function equivalents of {{REVISIONID}}, {{REVISIONTIMESTAMP}} (and friends) and {{REVISIONUSER}} magic words. These parser functions are marked as expensive and cache their results
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r51424Reverted r49575, {{revisionid:...}} due to unresolved CR comments and the gen...tstarling17:09, 3 June 2009

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r16659* (bug 6092) Introduce magic words {{REVISIONDAY}}, {{REVISIONDAY2}, {{REVISI...collinj17:20, 26 September 2006

Comments

#Comment by Melancholie (talk | contribs)   05:31, 17 April 2009

Is there now a magic word + parser function, or does the magic word just get "imported"? See https://bugzilla.wikimedia.org/show_bug.cgi?id=6092#c23

#Comment by Catrope (talk | contribs)   09:39, 17 April 2009

See the bug, comment 24.

#Comment by Happy-melon (talk | contribs)   13:25, 20 April 2009

What have I got to do with it?? :D

#Comment by Melancholie (talk | contribs)   05:32, 17 April 2009

{{REVISIONUSER}} (<nowiki> ;-)

#Comment by Spidern (talk | contribs)   03:06, 21 April 2009

Oh , you silly person you.

#Comment by Zzyzx11 (talk | contribs)   03:12, 21 April 2009

How in the world did I get into this conversation?

#Comment by Zzyzx11 (talk | contribs)   03:24, 21 April 2009

I mean is way better than me... especially when that user saved the entire Wikipedia on 20140728223207 :D

#Comment by Voice of All (talk | contribs)   07:02, 21 April 2009
#Comment by Brion VIBBER (talk | contribs)   00:31, 29 April 2009

There's a lot of code duplication here; I'd recommend refactoring the code a bit so it's easier to maintain.

#Comment by Kronoxt (talk | contribs)   01:19, 15 May 2009

Are you talking about me?? Hoe I got implicated in that... anyways.

#Comment by Kronoxt (talk | contribs)   02:12, 15 May 2009

&EDIT : **How I got involved in that

#Comment by Shinjiman (talk | contribs)   15:29, 1 June 2009

Me too, how I got involved in that?

#Comment by Splarka (talk | contribs)   08:19, 30 May 2009

Hey, Someone should make sure this can't be used as Template:CURRENTUSER by giving an invalid/bad/deleted/hidden title.

#Comment by Capmo (talk | contribs)   07:08, 4 June 2009

Hey, it took me 20min to understand why you were all talking about me, lol! Especially , you naughty boy!

#Comment by Pinky (talk | contribs)   01:27, 16 June 2009

test ~~~

Status & tagging log