MediaWiki r4934 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r4933‎ | r4934 (on ViewVC)‎ | r4935 >
Date:05:23, 27 August 2004
Author:jeluf
Status:old
Tags:
Comment:
ENH#169: Provide plugin interface for skins. See also module "sampleskin" in extensions.
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/SpecialPreferences.php
@@ -382,8 +382,13 @@
383383 } else {
384384 $checked = "";
385385 }
 386+ if ( isset( $skinNames[$skinkey] ) ) {
 387+ $sn = $skinNames[$skinkey];
 388+ } else {
 389+ $sn = $skinname;
 390+ }
386391 $wgOut->addHTML( "<div><label><input type='radio' name=\"wpSkin\"
387 - value=\"$skinkey\"$checked /> {$skinNames[$skinkey]}</label></div>\n" );
 392+ value=\"$skinkey\"$checked /> {$sn}</label></div>\n" );
388393 }
389394 $wgOut->addHTML( "</fieldset>\n\n" );
390395
Index: trunk/phase3/includes/DefaultSettings.php
@@ -511,6 +511,7 @@
512512 $wgAllowRealName = true;
513513
514514 # Extensions
 515+$wgSkinExtensionFunctions = array();
515516 $wgExtensionFunctions = array();
516517
517518 # Allow user Javascript page?
Index: trunk/phase3/includes/Setup.php
@@ -236,6 +236,14 @@
237237 wfProfileOut( $fname.'-BlockCache' );
238238 wfProfileIn( $fname.'-User' );
239239
 240+# Extension setup functions
 241+# Entries should be added to this variable during the inclusion
 242+# of the extension file. This allows the extension to perform
 243+# any necessary initialisation in the fully initialised environment
 244+foreach ( $wgSkinExtensionFunctions as $func ) {
 245+ $func();
 246+}
 247+
240248 if( $wgCommandLineMode ) {
241249 # Used for some maintenance scripts; user session cookies can screw things up
242250 # when the database is in an in-between state.

Follow-up revisions

Rev.Commit summaryAuthorDate
r87487Kill $wgSkinExtensionFunctions. Way back in r4934 when it was introduced, it ...demon06:29, 5 May 2011

Status & tagging log

  • 01:56, 13 October 2010 ^demon (Talk | contribs) changed the status of r4934 [removed: new added: old]
Personal tools
Namespaces

Variants
Views
Actions
Navigation
Support
Download
Development
Communication
Toolbox