MediaWiki r48984 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r48983‎ | r48984 (on ViewVC)‎ | r48985 >
Date:08:55, 29 March 2009
Author:philip
Status:reverted (Comments)
Tags:
Comment:
Add group convertsion support for LanguageConverter. New magic word "{{GROUPCONVERT:xxx}}" enabled for this new feature. You can set related conversion rules in [[MediaWiki:Groupconversiontable-xxx]].
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r48985Follow up on r48984, RELEASE-NOTES modified.philip09:20, 29 March 2009
r51405Reverted r48984. Fragile, doesn't work if memcached is enabled. See CodeReview.tstarling14:51, 3 June 2009
r51406Follow-up to r51405 (Reverted r48984)....siebrand15:02, 3 June 2009

Comments

#Comment by Tim Starling (talk | contribs)   08:21, 19 May 2009

I don't see how this could work. Isn't loadTables() called before mGroups is filled?

#Comment by PhiLiP (talk | contribs)   17:28, 19 May 2009

loadTables() called after mGroups is filled. I have tested it on my own MediaWiki server (and passed) before I commit it.

#Comment by Tim Starling (talk | contribs)   14:48, 3 June 2009

Only because of luck, not good design. If any extension calls $wgParser->parse() before the primary wikitext is parsed, this will break. It's broken with memcached enabled, because the current set of group conversion tables is saved into memcached, merged with the default tables, and then used for every page regardless of the groups that that page defines. So it won't work on Wikimedia.

Status & tagging log