MediaWiki r47769 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r47768‎ | r47769 (on ViewVC)‎ | r47770 >
Date:22:27, 24 February 2009
Author:werdna
Status:ok (Comments)
Tags:
Comment:
Make $wgUseTagFilter disable just filtering, rather than all display query modification
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/ChangeTags.php
===================================================================
--- trunk/phase3/includes/ChangeTags.php	(revision 47768)
+++ trunk/phase3/includes/ChangeTags.php	(revision 47769)
@@ -93,10 +93,6 @@
 	static function modifyDisplayQuery( &$tables, &$fields,  &$conds, &$join_conds, $filter_tag = false ) {
 		global $wgRequest, $wgUseTagFilter;
 		
-		if( !$wgUseTagFilter ) {
-			return;
-		}
-		
 		if ($filter_tag === false) {
 			$filter_tag = $wgRequest->getVal( 'tagfilter' );
 		}
@@ -118,7 +114,7 @@
 		$join_conds['tag_summary'] = array( 'LEFT JOIN', "ts_$join_cond=$join_cond" );
 		$fields[] = 'ts_tags';
 		
-		if ($filter_tag) {
+		if ($wgUseTagFilter && $filter_tag) {
 			// Somebody wants to filter on a tag.
 			// Add an INNER JOIN on change_tag
 

Comments

#Comment by Brion VIBBER (Talk | contribs)   22:43, 24 February 2009

Fixes bug in r47767

Status & tagging log

Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox