MediaWiki r46630 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r46629‎ | r46630 (on ViewVC)‎ | r46631 >
Date:01:35, 31 January 2009
Author:mrzman
Status:ok (Comments)
Tags:
Comment:
Allow the {{NAMESPACE}}, {{TALKSPACE}}, and {{SUBJECTSPACE}} magic words (and their urlencoding versions) to be used as parser functions to return the desired namespace for a given title.
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r46662(bug 8249) Followup to r46630, add parser function versions of the various PA...mrzman22:25, 31 January 2009

Comments

#Comment by Simetrical (talk | contribs)   23:45, 31 January 2009

I see no limitations here on the number of queries this could cause per page. Shouldn't this be limited like #ifexist and pagesincategory?

#Comment by Simetrical (talk | contribs)   23:46, 31 January 2009

Wait, sorry, this shouldn't cause queries, of course. They never need be unstubbed.

#Comment by Werdna (talk | contribs)   23:38, 11 February 2009

Don't these parser functions need to be localised and added to MagicWords.php?

See r46822 for an example of this...

#Comment by Mr.Z-man (talk | contribs)   00:12, 12 February 2009

they're already there as magic words

#Comment by Werdna (talk | contribs)   00:15, 12 February 2009

Oh, right.

Status & tagging log

  • 02:17, 18 February 2009 Brion VIBBER (talk | contribs) changed the status of r46630 [removed: new added: ok]
  • 00:15, 12 February 2009 Werdna (talk | contribs) changed the status of r46630 [removed: fixme added: new]
  • 23:38, 11 February 2009 Werdna (talk | contribs) changed the status of r46630 [removed: new added: fixme]
  • 23:46, 31 January 2009 Simetrical (talk | contribs) changed the status of r46630 [removed: fixme added: new]
  • 23:45, 31 January 2009 Simetrical (talk | contribs) changed the status of r46630 [removed: new added: fixme]