MediaWiki r46560 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r46559‎ | r46560 (on ViewVC)‎ | r46561 >
Date:23:04, 29 January 2009
Author:werdna
Status:deferred
Tags:
Comment:
Minor fixes for r46557
* Don't show revisions in the examiner which can't be examined.
* Fill out some forgotten interface messages.
Modified paths:

Diff [purge]

Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewExamine.php
===================================================================
--- trunk/extensions/AbuseFilter/Views/AbuseFilterViewExamine.php	(revision 46559)
+++ trunk/extensions/AbuseFilter/Views/AbuseFilterViewExamine.php	(revision 46560)
@@ -64,6 +64,10 @@
 		$counter = 1;
 
 		while ( $row = $dbr->fetchObject( $res ) ) {
+			## Incompatible stuff.
+			if ( !$row->rc_this_oldid && !in_array( $row->rc_log_action, array( 'move', 'newusers' ) ) )
+				continue;
+			
 			$rc = RecentChange::newFromRow( $row );
 			$rc->counter = $counter++;
 			$output .= $changesList->recentChangesLine( $rc, false );
Index: trunk/extensions/AbuseFilter/AbuseFilter.i18n.php
===================================================================
--- trunk/extensions/AbuseFilter/AbuseFilter.i18n.php	(revision 46559)
+++ trunk/extensions/AbuseFilter/AbuseFilter.i18n.php	(revision 46560)
@@ -343,6 +343,8 @@
 	'abusefilter-examine-match' => 'The filter matched this change.',
 	'abusefilter-examine-nomatch' => 'The filter did not match this change.',
 	'abusefilter-examine-syntaxerror' => 'The filter has invalid syntax',
+	'abusefilter-examine-notfound' => 'The change you requested could not be found.',
+	'abusefilter-examine-incompatible' => 'The change you requested is not supported by the Abuse Filter',
 );
 
 /** Message documentation (Message documentation)

Status & tagging log

  • 00:06, 6 February 2009 Werdna (Talk | contribs) changed the status of r46560 [removed: new added: deferred]
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox