MediaWiki r46481 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r46480‎ | r46481 (on ViewVC)‎ | r46482 >
Date:20:09, 28 January 2009
Author:werdna
Status:deferred
Tags:
Comment:
Style disabled and deleted filters in light gray, for visual identification.
Modified paths:

Diff [purge]

Index: trunk/extensions/AbuseFilter/abusefilter.css
===================================================================
--- trunk/extensions/AbuseFilter/abusefilter.css	(revision 46480)
+++ trunk/extensions/AbuseFilter/abusefilter.css	(revision 46481)
@@ -38,4 +38,12 @@
 
 td.mw-abuselog-var {
 	width: 30%;
+}
+
+tr.mw-abusefilter-list-disabled, tr.mw-abusefilter-list-disabled td {
+	color: #666666;
+}
+
+tr.mw-abusefilter-list-deleted, tr.mw-abusefilter-list-deleted td {
+	color: #aaaaaa;
 }
\ No newline at end of file
Index: trunk/extensions/AbuseFilter/Views/AbuseFilterViewList.php
===================================================================
--- trunk/extensions/AbuseFilter/Views/AbuseFilterViewList.php	(revision 46480)
+++ trunk/extensions/AbuseFilter/Views/AbuseFilterViewList.php	(revision 46481)
@@ -201,6 +201,16 @@
 		return 'af_id';
 	}
 
+	function getRowClass( $row ) {
+		if ($row->status & 1) {
+			return 'mw-abusefilter-list-enabled';
+		} elseif ($row->status & 2) {
+			return 'mw-abusefilter-list-deleted';
+		} else {
+			return 'mw-abusefilter-list-disabled';
+		}
+	}
+
 	function isFieldSortable($name) {
 		$sortable_fields = array( 'af_id', 'status', 'af_hit_count', 'af_throttled', 'af_user_text', 'af_timestamp' );
 		return in_array( $name, $sortable_fields );

Status & tagging log

Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox