r46460 - Code Review

From MediaWiki.org

Jump to: navigation, search
Repository:MediaWiki
Revision:< r46459 | r46460 (on ViewVC) | r46461 >
Date:19:08, 28 January 2009
Author:werdna
Status:new (Comments)
Tags:
Comment:Branch merge of change-tagging branch with trunk
-- Introduce tagging of individual changes (revisions, logs, and on recentchanges). The tags are customisable, and currently settable by the Abuse Filter and by the TorBlock extension. The tags can be styled on the various pages on which they appear.
-- Introduces a schema change, three new tables (valid_tag, change_tag, and tag_summary).
Modified paths:

Follow-up revisions

RevisionCommit summaryAuthorDate
r46462Follow up r46460: Add new messages to messages.incraymond19:19, 28 January 2009
r46875Update Postgres schema per r46460ialex20:55, 5 February 2009
r46941Fix for r46460: use "CREATE INDEX ... ON ..." rather than inside "CREATE TABLE" ...ialex21:17, 6 February 2009

Comments

#Comment by Siebrand (Talk | contribs)   23:11, 28 January 2009
  1. Should the tag filter field maybe be hidden if no labels are defined? See betawiki:Special:Contributions/Lockal and betawiki:Special:Tags. As I have no idea what tags are, and there are no tags defined, this is highly confusing.
  2. there's an issue with the link description for Special:Tags (displays as "&lt;tags&gt;"). See betawiki:Special:SpecialPages at the bottom of the page.
  3. The Special:Tags should get a wgSpecialPageGroups
#Comment by Werdna (Talk | contribs)   23:03, 5 February 2009

All fixed on svn. Thanks for the feedback.

#Comment by Werdna (Talk | contribs)   22:55, 11 February 2009

This commit is 'resolved' as-is, but it's such a huge change that I'm leaving it as 'new' until somebody has a good look at it and says that those were the only problems.

#Comment by Werdna (Talk | contribs)   01:20, 12 February 2009

Fix in r46674.

#Comment by Werdna (Talk | contribs)   01:21, 12 February 2009

Fix in r46675.

Retrieved from "http://www.mediawiki.org/wiki/Special:Code/MediaWiki/46460"
Views
Toolbox