MediaWiki r45587 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r45586‎ | r45587 (on ViewVC)‎ | r45588 >
Date:23:21, 8 January 2009
Author:mrzman
Status:ok (Comments)
Tags:
Comment:
(bug 9947) Add PROTECTIONLEVEL parser function to return the protection level for a given action (e.g. edit, move) for the current page.
Modified paths:

Diff [purge]

Loading diff…

Comments

#Comment by IAlex (talk | contribs)   10:00, 9 January 2009

One little thing: adding a variable ID to MagicWords::$mVariableIDs means that you'll handle it in Parser::getVariableValue(), which is not the case here. You don't need to add a magic word ID there if it'll be used for parser function. The problem is now that you can add "{{PROTECTIONLEVEL}}" in wikitext, but the result will always be an empty string, even if the page is a protected page.

#Comment by Mr.Z-man (talk | contribs)   18:29, 9 January 2009

removed in r45609. Some others can probably be removed from there too...

#Comment by Brion VIBBER (talk | contribs)   00:05, 14 January 2009

We're a bit leery of this.

#Comment by Brion VIBBER (talk | contribs)   00:06, 14 January 2009

[4:05pm] TimStarling: brion: I would say leave it in, and make sure protection changes do indeed invalidate the parser cache

#Comment by Mr.Z-man (talk | contribs)   00:36, 14 January 2009

Article::updateRestrictions() updates page_touched, which should invalidate the parser cache.

#Comment by Brion VIBBER (talk | contribs)   00:45, 14 January 2009

w00t

#Comment by Aaron Schulz (talk | contribs)   23:06, 20 January 2009

So this is OK, right?

Status & tagging log