MediaWiki r44241 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r44240‎ | r44241 (on ViewVC)‎ | r44242 >
Date:20:08, 4 December 2008
Author:ialex
Status:ok
Tags:
Comment:
\o/ \o/ \o/ :)

Fixing JS bugs affecting Internet Explorer, part one: No form shown in Special:Configure, Special:Extensions and Special:ViewConfig.
I passed some hours trying to fix this silly bug and guess what: it just need a <tbody> tag between <table> and <tr>.

This is not the only bug in IE, but at least there's something on the page :)
Modified paths:

Diff [purge]

Index: trunk/extensions/Configure/Configure.php
===================================================================
--- trunk/extensions/Configure/Configure.php	(revision 44240)
+++ trunk/extensions/Configure/Configure.php	(revision 44241)
@@ -147,7 +147,7 @@
 /**
  * Styles versions, you shouldn't change it
  */
-$wgConfigureStyleVersion = '15';
+$wgConfigureStyleVersion = '16';
 
 # Adding new rights...
 $wgAvailableRights[] = 'configure';
Index: trunk/extensions/Configure/Configure.js
===================================================================
--- trunk/extensions/Configure/Configure.js	(revision 44240)
+++ trunk/extensions/Configure/Configure.js	(revision 44241)
@@ -110,8 +110,8 @@
 	toggleToc.onmousedown = toggleToc.onclick = configTocToggle;
 	toggleToc.appendChild( getArrowImg( 'l' ) );
 
-	var par = configform.parentNode;
 	var table = document.createElement( 'table' );
+	var tbody = document.createElement( 'tbody' );
 	var tr = document.createElement( 'tr' );
 	var tdToc = document.createElement( 'td' );
 	var tdForm = document.createElement( 'td' );
@@ -122,8 +122,9 @@
 	tdForm.className = 'config-col-form';
 	tr.appendChild( tdToc );
 	tr.appendChild( tdForm );
-	table.appendChild( tr );
-	par.appendChild( table );
+	tbody.appendChild( tr );
+	table.appendChild( tbody );
+	document.getElementById( 'configure-form' ).appendChild( table );
 
 	// Associative tables
 	// ------------------

Status & tagging log

Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox