MediaWiki r44228 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r44227‎ | r44228 (on ViewVC)‎ | r44229 >
Date:13:29, 4 December 2008
Author:werdna
Status:ok
Tags:
Comment:
Don't show [+] for sections with only one subsection, it looks stupid.
Modified paths:

Diff [purge]

Index: trunk/extensions/Configure/Configure.js
===================================================================
--- trunk/extensions/Configure/Configure.js	(revision 44227)
+++ trunk/extensions/Configure/Configure.js	(revision 44228)
@@ -45,13 +45,18 @@
 			if (i === 0) {
 				li.className = 'selected';
 			}
+			
+			var headers = children[i].getElementsByTagName( 'h2' );
+			var tables = getElementsByClassName( children[i], 'table', 'configure-table' );
 
-			var a = document.createElement('a');
-			a.onmousedown = a.onclick = configTocToggleElement;
-			a.tocId = i;
-			a.collapsed = true;
-			a.appendChild( document.createTextNode( '[+]' ) );
-			li.appendChild(a);
+			if (headers.length > 1 && headers.length == tables.length) {
+				var a = document.createElement('a');
+				a.onmousedown = a.onclick = configTocToggleElement;
+				a.tocId = i;
+				a.collapsed = true;
+				a.appendChild( document.createTextNode( '[+]' ) );
+				li.appendChild(a);
+			}
 
 			var a = document.createElement('a');
 			a.href = '#' + children[i].id;
@@ -65,9 +70,7 @@
 			a.appendChild( document.createTextNode( legend ) );
 			li.appendChild(a);
 
-			var headers = children[i].getElementsByTagName( 'h2' );
-			var tables = getElementsByClassName( children[i], 'table', 'configure-table' );
-			if( headers.length == tables.length ){
+			if( headers.length == tables.length && headers.length > 1 ){
 				var len = headers.length;
 				toc.subLen[i] = len;
 				var span = document.createElement( 'span' );

Status & tagging log

Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox