MediaWiki r43632 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:< r43631‎ | r43632 (on ViewVC)‎ | r43633 >
Date:20:04, 17 November 2008
Author:brion
Status:ok
Tags:
Comment:
Revert r43592 "Pass the user object in MakeGlobalVariablesScript in case some variables are user-dependent."
As a UI thingy, $wgUser will be the only relevant user object here; there's no circumstance in which we might pass some other user object. No reason to pass it to hooks just on the off chance that they might use it, then...
Modified paths:

Diff [purge]

Index: trunk/phase3/docs/hooks.txt
——@@ -889,7 +889,6 @@
890890 'MakeGlobalVariablesScript': called right before Skin::makeVariablesScript is executed
891891 &$vars: variable (or multiple variables) to be added into the output
892892 of Skin::makeVariablesScript
893 -&$wgUser: user (object) currently loading the skin
894893
895894 'MarkPatrolled': before an edit is marked patrolled
896895 $rcid: ID of the revision to be marked patrolled
Index: trunk/phase3/includes/Skin.php
——@@ -409,7 +409,7 @@
410410 $vars['wgAjaxWatch'] = $msgs;
411411 }
412412
413 - wfRunHooks('MakeGlobalVariablesScript', array( &$vars, &$wgUser ) );
 413+ wfRunHooks('MakeGlobalVariablesScript', array(&$vars));
414414
415415 return self::makeVariablesScript( $vars );
416416 }

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r43592Pass the user object in MakeGlobalVariablesScript in case some variables are ...demon02:33, 17 November 2008

Status & tagging log

Retrieved from "http://www.mediawiki.org/wiki/Special:Code/MediaWiki/43632"