r43499 - Code Review

From MediaWiki.org

Jump to: navigation, search
Repository:MediaWiki
Revision:< r43498 | r43499 (on ViewVC) | r43500 >
Date:19:11, 14 November 2008
Author:brion
Status:ok (Comments)
Tags:
Comment:Reverting in-development search changes pending fixing.

Can we please do these sorts of experimental developments on branches before putting them to trunk? Our trunk is meant to be functional and ready to deploy at all times; doing experiments on trunk delays deployments because we have to test and fix them or roll them back.

Reverted:
r43376
r43385
r43403
r43404
r43405
r43406
r43423

Issues I noticed during a few minutes testing:
* Background color mismatch on the frameset for wikis that set a BG color on Special:
* 'browse pages with this prefix' is kind of funky in "Pages & Project" (goes to main namespace only)
* Which namespaces are in "Pages & Project" is not discoverable
* Default link to nonexistent help page Project:Searching kind of sucks. we should avoid doing those by default. It used to link to Help:Contents; any reason for the change from one page which might have previously existed to one which doesn't?
* "Create the page "Stuff" on this wiki!" - Double page creation links seem kind of weird. There should only be one, otherwise why have two?
* Bad prefix link output when search terms are not a valid wiki title
* We've lost the Whatlinkshere link from the old results
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

RevisionCommit summaryAuthorDate
r43512Recover from r43499. Gotta love having all messages in a database :)siebrand23:59, 14 November 2008

Comments

#Comment by Aaron Schulz (Talk | contribs)   23:24, 14 November 2008

Background color mismatch would probably be a local issue. Also, the prefix link there has the same issue as the one in use now.

#Comment by Aaron Schulz (Talk | contribs)   23:29, 14 November 2008

Is 'Whatlinkshere' even useful here?

Status & tagging log

Retrieved from "http://www.mediawiki.org/wiki/Special:Code/MediaWiki/43499"
Views
Toolbox