r43117 - Code Review

From MediaWiki.org

Jump to: navigation, search
Repository:MediaWiki
Revision:r43116 | r43117 (on ViewVC) | r43118 >
Date:10:13, 3 November 2008
Author:catrope
Status:ok
Tags:api 
Comment:API: (bug 16225) apfrom=Talk:Foo behaved like apfrom=Foo because Talk: was interpreted as a namespace prefix. This caused bugs when trying to query-continue with a title like Talk:Talk:Foo. Other XXfrom and XXprefix parameters probably had this bug as well.
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/api/ApiQueryBase.php
===================================================================
--- trunk/phase3/includes/api/ApiQueryBase.php	(revision 43116)
+++ trunk/phase3/includes/api/ApiQueryBase.php	(revision 43117)
@@ -338,7 +338,7 @@
 		$t = Title::newFromText($title);
 		if(!$t)
 			$this->dieUsageMsg(array('invalidtitle', $title));
-		return $t->getDbKey();
+		return $t->getPrefixedDbKey();
 	}
 
 	/**
Index: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES	(revision 43116)
+++ trunk/phase3/RELEASE-NOTES	(revision 43117)
@@ -397,6 +397,7 @@
 * (bug 16105) Image metadata attributes containing spaces result in invalid XML
 * (bug 16126) Added siprop=magicwords to meta=siteinfo
 * (bug 16159) Added wlshow=patrolled|!patrolled to list=watchlist
+* (bug 16225) Titles like Talk:Talk:Foo broke apfrom and friends
 
 === Languages updated in 1.14 ===
 
Views
Toolbox