MediaWiki r43065 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r43064‎ | r43065 (on ViewVC)‎ | r43066 >
Date:05:32, 2 November 2008
Author:soxred93
Status:old (Comments)
Tags:
Comment:
(bug 15125) Add Public Domain to default options when installing. Patch by Nathan Larson.
Modified paths:

Diff [purge]

Index: trunk/phase3/skins/common/images/Public-domain.png
Cannot display: file marked as a binary type.
svn:mime-type = image/png
Property changes on: trunk/phase3/skins/common/images/Public-domain.png
___________________________________________________________________
Added: svn:mime-type
11 + image/png
Index: trunk/phase3/CREDITS
@@ -57,6 +57,7 @@
5858 * Mike Horvath
5959 * Mormegil
6060 * Nathaniel Herman
 61+* Nathan Larson
6162 * RememberTheDot
6263 * ST47
6364
Index: trunk/phase3/config/index.php
@@ -691,6 +691,11 @@
692692 $conf->RightsIcon = '${wgScriptPath}/skins/common/images/gnu-fdl.png';
693693 } elseif( $conf->License == "none" ) {
694694 $conf->RightsUrl = $conf->RightsText = $conf->RightsCode = $conf->RightsIcon = "";
 695+} elseif( $conf->License == "pd" ) {
 696+ $conf->RightsUrl = "http://en.wikipedia.org/wiki/Public_domain";
 697+ $conf->RightsText = "Public Domain";
 698+ $conf->RightsCode = "pd";
 699+ $conf->RightsIcon = '${wgScriptPath}/skins/common/images/public-domain.png';
695700 } else {
696701 $conf->RightsUrl = importRequest( "RightsUrl", "" );
697702 $conf->RightsText = importRequest( "RightsText", "" );
@@ -1180,6 +1185,7 @@
11811186
11821187 <ul class="plain">
11831188 <li><?php aField( $conf, "License", "No license metadata", "radio", "none" ); ?></li>
 1189+ <li><?php aField( $conf, "License", "Public Domain", "radio", "pd" ); ?></li>
11841190 <li><?php aField( $conf, "License", "GNU Free Documentation License 1.2 (Wikipedia-compatible)", "radio", "gfdl" ); ?></li>
11851191 <li><?php
11861192 aField( $conf, "License", "A Creative Commons license - ", "radio", "cc" );
@@ -1588,7 +1594,7 @@
15891595
15901596 # Add slashes to strings for double quoting
15911597 $slconf = array_map( "escapePhpString", get_object_vars( $conf ) );
1592 - if( $conf->License == 'gfdl' ) {
 1598+ if( $conf->License == 'gfdl' || $conf->License == 'pd' ) {
15931599 # Needs literal string interpolation for the current style path
15941600 $slconf['RightsIcon'] = $conf->RightsIcon;
15951601 }
Index: trunk/phase3/RELEASE-NOTES
@@ -186,7 +186,7 @@
187187 * (bug 15820) Special:BlockIP shows a notice if the user being blocked is already
188188 directly blocked
189189 * (bug 13710) Allow to force "watch this" checkbox via URL using para "watchthis"
190 -
 190+* (bug 15125) Add Public Domain to default options when installing. Patch by Nathan Larson.
191191 === Bug fixes in 1.14 ===
192192
193193 * (bug 14907) DatabasePostgres::fieldType now defined.

Image changes

Index: /trunk/phase3/skins/common/images/Public-domain.png
added

Comments

#Comment by Bryan (Talk | contribs)   12:50, 2 November 2008

Where did this image come from? Is it PD or in any other GPL compatible license?

#Comment by Nathan Larson (Talk | contribs)   15:44, 2 November 2008

I created it from the public domain image at http://commons.wikimedia.org/wiki/Image:PD-icon.png and posted the modified image to http://www.mediawiki.org/wiki/Image:Public_domain.png , having released it into the public domain.

#Comment by NSK Nikolaos S. Karastathis (Talk | contribs)   15:57, 9 November 2008

Please change the URL to point to the Creative Commons Public Domain dedication rather than to an encyclopedic article, which is in fact a live link that could at any time be vandalised rather than a stable citation

Status & tagging log

  • 15:36, 12 September 2011 Meno25 (Talk | contribs) changed the status of r43065 [removed: ok added: old]
Personal tools
Namespaces

Variants
Views
Actions
Navigation
Support
Download
Development
Communication
Toolbox