MediaWiki r41961 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r41960‎ | r41961 (on ViewVC)‎ | r41962 >
Date:08:26, 11 October 2008
Author:tstarling
Status:old (Comments)
Tags:
Comment:
* Reintroduce user page move permission as per r41465, generally useful regardless of whether the Renameuser extension is in use. Do the check in Title::getUserPermissionsErrorsInternal(), so that the move page tab won't be displayed on user pages for users who can't move them.
* Use error message text suitable for humans. Be specific about whether the source or the destination is the problem, say what the namespace is for those people who don't get namespaces, don't introduce unnecessary jargon words like "root" for a page that isn't a subpage.
* Fixed incorrect display of movenotallowed for immobile namespaces, use the new specific error messages.
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r41963Continuation of r41961: remove this move page hook since I just readded the f...tstarling08:33, 11 October 2008
r95756Fix a message key typo in r41961 (!!), which didn't matter before because the...catrope11:39, 30 August 2011

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r41465Adding a new right, move-rootuserpages....nicdumz07:51, 1 October 2008

Comments

#Comment by Voice of All (talk | contribs)   18:25, 11 October 2008

Where does move-target come from?

#Comment by Brion VIBBER (talk | contribs)   02:47, 13 October 2008

Title::isValidMoveOperation() uses separate actions for the move source and move target when building up the permission/error checks:

			$errors = wfArrayMerge($errors, 
					$this->getUserPermissionsErrors('move', $wgUser),
					$this->getUserPermissionsErrors('edit', $wgUser),
					$nt->getUserPermissionsErrors('move-target', $wgUser),
					$nt->getUserPermissionsErrors('edit', $wgUser));

Status & tagging log

  • 15:32, 12 September 2011 Meno25 (talk | contribs) changed the status of r41961 [removed: ok added: old]