r41940 - Code Review

From MediaWiki.org

Jump to: navigation, search
Repository:MediaWiki
Revision:r41939 | r41940 (on ViewVC) | r41941 >
Date:17:43, 10 October 2008
Author:simetrical
Status:ok
Tags:nostgalgia 
Comment:(bug 15928) Make special pages dropdown inline

There was a weird extra "|" at the end of lines in Nostalgia (probably other non-MonoBook skins too). Upon investigation, I found that the special pages dropdown (which immediately followed that separator but on the next line) had a class="inline", which actually did nothing but whose intent was fairly obvious. I removed the presentational class and just styled it using the id, so now the separator actually . . . separates.
Modified paths:

Diff [purge]

Index: trunk/phase3/skins/common/oldshared.css
===================================================================
--- trunk/phase3/skins/common/oldshared.css	(revision 41939)
+++ trunk/phase3/skins/common/oldshared.css	(revision 41940)
@@ -416,3 +416,7 @@
 	vertical-align: middle;
 	font-size: 90%;
 }
+
+form#specialpages {
+	display: inline;
+}
Index: trunk/phase3/includes/DefaultSettings.php
===================================================================
--- trunk/phase3/includes/DefaultSettings.php	(revision 41939)
+++ trunk/phase3/includes/DefaultSettings.php	(revision 41940)
@@ -1385,7 +1385,7 @@
  * to ensure that client-side caches don't keep obsolete copies of global
  * styles.
  */
-$wgStyleVersion = '180';
+$wgStyleVersion = '181';
 
 
 # Server-side caching:
Index: trunk/phase3/includes/Skin.php
===================================================================
--- trunk/phase3/includes/Skin.php	(revision 41939)
+++ trunk/phase3/includes/Skin.php	(revision 41940)
@@ -1390,7 +1390,7 @@
 		$sp = wfMsg( 'specialpages' );
 		$spp = $wgContLang->specialPage( 'Specialpages' );
 
-		$s = '<form id="specialpages" method="get" class="inline" ' .
+		$s = '<form id="specialpages" method="get" ' .
 		  'action="' . htmlspecialchars( "{$wgServer}{$wgRedirectScript}" ) . "\">\n";
 		$s .= "<select name=\"wpDropdown\">\n";
 		$s .= "<option value=\"{$spp}\">{$sp}</option>\n";
Index: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES	(revision 41939)
+++ trunk/phase3/RELEASE-NOTES	(revision 41940)
@@ -259,6 +259,7 @@
 * (bug 15795) Special:Userrights is now listed on Special:SpecialPages when the
   user can only change his rights
 * (bug 15846) Categories "leak" from older revisions in certain circumstances
+* (bug 15928) Special pages dropdown should be inline in non-MonoBook skins
 
 === API changes in 1.14 ===
 
Views
Toolbox