MediaWiki r41923 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r41922‎ | r41923 (on ViewVC)‎ | r41924 >
Date:06:00, 10 October 2008
Author:krimpet
Status:old
Tags:
Comment:
Fix template-included categories from 'leaking' from older revisions when cascading protection is on.
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/Article.php
===================================================================
--- trunk/phase3/includes/Article.php	(revision 41922)
+++ trunk/phase3/includes/Article.php	(revision 41923)
@@ -3522,7 +3522,7 @@
 			$wgUseFileCache = false;
 		}
 
-		if ( !wfReadOnly() && $this->mTitle->areRestrictionsCascading() ) {
+		if ( $this->isCurrent() && !wfReadOnly() && $this->mTitle->areRestrictionsCascading() ) {
 			// templatelinks table may have become out of sync,
 			// especially if using variable-based transclusions.
 			// For paranoia, check if things have changed and if
Index: trunk/phase3/RELEASE-NOTES
===================================================================
--- trunk/phase3/RELEASE-NOTES	(revision 41922)
+++ trunk/phase3/RELEASE-NOTES	(revision 41923)
@@ -258,6 +258,7 @@
 * (bug 15869) Nostalgia skin does not show page title in printable mode
 * (bug 15795) Special:Userrights is now listed on Special:SpecialPages when the
   user can only his rights
+* (bug 15846) Categories "leak" from older revisions in certain circumstances
 
 === API changes in 1.14 ===
 

Status & tagging log

  • 15:32, 12 September 2011 Meno25 (Talk | contribs) changed the status of r41923 [removed: ok added: old]
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox