MediaWiki r41831 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r41830‎ | r41831 (on ViewVC)‎ | r41832 >
Date:04:44, 8 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
(bug 15432) Contribs links at blockip. Moved "edit" message and shorten some.
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialBlockip.php
===================================================================
--- trunk/phase3/includes/specials/SpecialBlockip.php	(revision 41830)
+++ trunk/phase3/includes/specials/SpecialBlockip.php	(revision 41831)
@@ -479,9 +479,11 @@
 	private function getConvenienceLinks() {
 		global $wgUser;
 		$skin = $wgUser->getSkin();
-		$links[] = $skin->makeLink ( 'MediaWiki:Ipbreason-dropdown', wfMsgHtml( 'ipb-edit-dropdown' ) );
+		$contribsPage = SpecialPage::getTitleFor( 'Contributions', $this->BlockAddress );
+		$links[] = $skin->link( $contribsPage, wfMsgHtml( 'ipb-blocklist-contibs', $this->BlockAddress ) );
 		$links[] = $this->getUnblockLink( $skin );
 		$links[] = $this->getBlockListLink( $skin );
+		$links[] = $skin->makeLink ( 'MediaWiki:Ipbreason-dropdown', wfMsgHtml( 'ipb-edit-dropdown' ) );
 		return '<p class="mw-ipb-conveniencelinks">' . implode( ' | ', $links ) . '</p>';
 	}
 
Index: trunk/phase3/languages/messages/MessagesEn.php
===================================================================
--- trunk/phase3/languages/messages/MessagesEn.php	(revision 41830)
+++ trunk/phase3/languages/messages/MessagesEn.php	(revision 41831)
@@ -2551,8 +2551,9 @@
 'ipb-edit-dropdown'               => 'Edit block reasons',
 'ipb-unblock-addr'                => 'Unblock $1',
 'ipb-unblock'                     => 'Unblock a username or IP address',
-'ipb-blocklist-addr'              => 'View existing blocks for $1',
+'ipb-blocklist-addr'              => 'Existing blocks for $1',
 'ipb-blocklist'                   => 'View existing blocks',
+'ipb-blocklist-contibs'           => 'Contributions for $1',
 'unblockip'                       => 'Unblock user',
 'unblockiptext'                   => 'Use the form below to restore write access to a previously blocked IP address or username.',
 'ipusubmit'                       => 'Unblock this address',

Follow-up revisions

Rev.Commit summaryAuthorDate
r41832Cleanup for r41831:...raymond06:44, 8 October 2008

Comments

#Comment by Mike.lifeguard (Talk | contribs)   05:30, 8 October 2008

Currently links to Contributions for when no user is specified - is that OK?

#Comment by Brion VIBBER (Talk | contribs)   20:45, 8 October 2008

r41832 fixes the message name typo, but the extra link is still there.

#Comment by Voice of All (Talk | contribs)   21:12, 8 October 2008

Fixed in r41852

#Comment by Brion VIBBER (Talk | contribs)   21:28, 8 October 2008

thanks!

Status & tagging log

  • 15:32, 12 September 2011 Meno25 (Talk | contribs) changed the status of r41831 [removed: resolved added: old]
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox