MediaWiki r41725 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r41724‎ | r41725 (on ViewVC)‎ | r41726 >
Date:04:24, 6 October 2008
Author:tstarling
Status:old
Tags:
Comment:
Fix for bug 8718. Cooperate with image centering by specifying widths on divs so that the margin:auto trick can work.
Modified paths:

Diff [purge]

Index: trunk/extensions/ImageMap/ImageMap_body.php
===================================================================
--- trunk/extensions/ImageMap/ImageMap_body.php	(revision 41724)
+++ trunk/extensions/ImageMap/ImageMap_body.php	(revision 41725)
@@ -289,11 +289,12 @@
 			} else {
 				$marginTop = -20;
 			}
-			$div->setAttribute( 'style', "height: {$thumbHeight}px" );
+			$div->setAttribute( 'style', "height: {$thumbHeight}px; width: {$thumbWidth}px; " );
 			$descWrapper = $div->appendChild( new DOMElement( 'div' ) );
 			$descWrapper->setAttribute( 'style', 
 				"margin-left: {$marginLeft}px; " . 
-				"margin-top: {$marginTop}px; "
+				"margin-top: {$marginTop}px; " .
+				"text-align: left;"
 			);
 
 			$descAnchor = $descWrapper->appendChild( new DOMElement( 'a' ) );

Status & tagging log

  • 15:32, 12 September 2011 Meno25 (Talk | contribs) changed the status of r41725 [removed: ok added: old]
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox