MediaWiki r41723 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r41722‎ | r41723 (on ViewVC)‎ | r41724 >
Date:03:49, 6 October 2008
Author:aaron
Status:old (Comments)
Tags:
Comment:
Remove some redundant "starting from" message cruft (bug 3327)
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/specials/SpecialRecentchanges.php
===================================================================
--- trunk/phase3/includes/specials/SpecialRecentchanges.php	(revision 41722)
+++ trunk/phase3/includes/specials/SpecialRecentchanges.php	(revision 41723)
@@ -593,18 +593,6 @@
 
 		$options = $nondefaults + $defaults;
 
-		if( $options['from'] )
-			$note = wfMsgExt( 'rcnotefrom', array( 'parseinline' ),
-				$wgLang->formatNum( $options['limit'] ),
-				$wgLang->timeanddate( $options['from'], true ) );
-		else
-			$note = wfMsgExt( 'rcnote', array( 'parseinline' ),
-				$wgLang->formatNum( $options['limit'] ),
-				$wgLang->formatNum( $options['days'] ),
-				$wgLang->timeAndDate( wfTimestampNow(), true ),
-				$wgLang->date( wfTimestampNow(), true ),
-				$wgLang->time( wfTimestampNow(), true ) );
-
 		# Sort data for display and make sure it's unique after we've added user data.
 		$wgRCLinkLimits[] = $options['limit'];
 		$wgRCLinkDays[] = $options['days'];
@@ -659,6 +647,6 @@
 		$rclinks = wfMsgExt( 'rclinks', array( 'parseinline', 'replaceafter' ),
 			$cl, $dl, $hl );
 		$rclistfrom = wfMsgExt( 'rclistfrom', array( 'parseinline', 'replaceafter' ), $tl );
-		return "$note<br />$rclinks<br />$rclistfrom";
+		return "$rclinks<br />$rclistfrom";
 	}
 }

Follow-up revisions

Rev.Commit summaryAuthorDate
r41811Follow up on r41723. 'rcnotefrom' is no longer in use.siebrand16:33, 7 October 2008
r42768Revert r41723 and follow-up r41811: rcnotefrom had one non-redundant field an...aaron15:35, 29 October 2008
r42769Redo r41723: still show rcnotefrom as needed, but not rcnote. Add rclegend me...aaron15:47, 29 October 2008

Comments

#Comment by Siebrand (Talk | contribs)   16:36, 7 October 2008

'rcnotefrom' messages removed in r41811.

Status & tagging log

  • 15:32, 12 September 2011 Meno25 (Talk | contribs) changed the status of r41723 [removed: ok added: old]
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox