MediaWiki r38407 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r38406‎ | r38407 (on ViewVC)‎ | r38408 >
Date:01:06, 2 August 2008
Author:jhsoby
Status:old
Tags:
Comment:
Gah, committed Linker.php by mistake. Reverting.
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/Linker.php
===================================================================
--- trunk/phase3/includes/Linker.php	(revision 38406)
+++ trunk/phase3/includes/Linker.php	(revision 38407)
@@ -1496,7 +1496,7 @@
 	 * Create a headline for content
 	 *
 	 * @param int    $level   The level of the headline (1-6)
-	 * @param string $attribs Any attrimbutes for the headline, starting with a space and ending with '>'
+	 * @param string $attribs Any attributes for the headline, starting with a space and ending with '>'
 	 *                        This *must* be at least '>' for no attribs
 	 * @param string $anchor  The anchor to give the headline (the bit after the #)
 	 * @param string $text    The text of the header
@@ -1505,7 +1505,7 @@
 	 * @return string HTML headline
 	 */
 	public function makeHeadline( $level, $attribs, $anchor, $text, $link ) {
-		return "<h$level id=\"$anchor\"$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
+		return "<a name=\"$anchor\"></a><h$level$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
 	}
 
 	/**

Status & tagging log

  • 15:29, 12 September 2011 Meno25 (Talk | contribs) changed the status of r38407 [removed: ok added: old]
Personal tools
Namespaces
Variants
Views
Actions
Site
Support
Download
Development
Communication
Toolbox