r38406 - Code Review

From MediaWiki.org

Jump to: navigation, search
Repository:MediaWiki
Revision:r38405 | r38406 (on ViewVC) | r38407 >
Date:01:04, 2 August 2008
Author:jhsoby
Status:ok
Tags:
Comment:Adding messages for new global group 'sysadmin'. Brion, Tim, Kate and JeLuF are all in it from the beginning.
Modified paths:

Diff [purge]

Index: trunk/phase3/includes/Linker.php
===================================================================
--- trunk/phase3/includes/Linker.php	(revision 38405)
+++ trunk/phase3/includes/Linker.php	(revision 38406)
@@ -1496,7 +1496,7 @@
 	 * Create a headline for content
 	 *
 	 * @param int    $level   The level of the headline (1-6)
-	 * @param string $attribs Any attributes for the headline, starting with a space and ending with '>'
+	 * @param string $attribs Any attrimbutes for the headline, starting with a space and ending with '>'
 	 *                        This *must* be at least '>' for no attribs
 	 * @param string $anchor  The anchor to give the headline (the bit after the #)
 	 * @param string $text    The text of the header
@@ -1505,7 +1505,7 @@
 	 * @return string HTML headline
 	 */
 	public function makeHeadline( $level, $attribs, $anchor, $text, $link ) {
-		return "<a name=\"$anchor\"></a><h$level$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
+		return "<h$level id=\"$anchor\"$attribs$link <span class=\"mw-headline\">$text</span></h$level>";
 	}
 
 	/**
Index: trunk/extensions/WikimediaMessages/WikimediaMessages.i18n.php
===================================================================
--- trunk/extensions/WikimediaMessages/WikimediaMessages.i18n.php	(revision 38405)
+++ trunk/extensions/WikimediaMessages/WikimediaMessages.i18n.php	(revision 38406)
@@ -53,16 +53,19 @@
 	# Global Wikimedia specific usergroups (defined on http://meta.wikimedia.org/wiki/Special:GlobalGroupPermissions)
 
 	'group-steward'         => 'Stewards',
+        'group-sysadmin'        => 'System administrators',
 	'group-Global_bot'      => 'Global bots',
 	'group-Global_rollback' => 'Global rollbackers',
 	'group-Ombudsmen'       => 'Ombudsmen',
 
 	'group-steward-member'         => 'steward',
+        'group-sysadmin-member'        => 'system administrator',
 	'group-Global_bot-member'      => 'global bot',
 	'group-Global_rollback-member' => 'global rollbacker',
 	'group-Ombudsmen-member'       => 'ombudsman',
 
 	'grouppage-steward'         => 'm:Stewards', # only translate this message to other languages if you have to change it
+        'grouppage-sysadmin'        => 'm:System administrators', # only translate this message to other languages if you have to change it
 	'grouppage-Global_bot'      => 'm:Global bot', # only translate this message to other languages if you have to change it
 	'grouppage-Global_rollback' => 'm:Global rollback', # only translate this message to other languages if you have to change it
 	'grouppage-Ombudsmen'       => 'm:Ombudsman commission', # only translate this message to other languages if you have to change it
Index: trunk/extensions/Translate/groups/mediawiki-defines.txt
===================================================================
--- trunk/extensions/Translate/groups/mediawiki-defines.txt	(revision 38405)
+++ trunk/extensions/Translate/groups/mediawiki-defines.txt	(revision 38406)
@@ -676,7 +676,7 @@
 
 Wikimedia Messages
 ignored = sidebar
-optional = grouppage-steward, grouppage-Global_bot, grouppage-Global_rollback, grouppage-Ombudsmen
+optional = grouppage-steward, grouppage-sysadmin, grouppage-Global_bot, grouppage-Global_rollback, grouppage-Ombudsmen
 
 Wiki Text Logged In Out
 
Views
Toolbox