r38290 - Code Review

From MediaWiki.org

Jump to: navigation, search
Repository:MediaWiki
Revision:r38289 | r38290 (on ViewVC) | r38291 >
Date:14:05, 31 July 2008
Author:jhsoby
Status:ok
Tags:
Comment:Putting #mw_header in one line in Modern; this way, when you triple-click then copy-paste the title of a page (in Firefox), you won't get two newlines as well.
Modified paths:

Diff [purge]

Index: trunk/phase3/skins/Modern.php
===================================================================
--- trunk/phase3/skins/Modern.php	(revision 38289)
+++ trunk/phase3/skins/Modern.php	(revision 38290)
@@ -98,9 +98,7 @@
  class="mediawiki <?php $this->text('nsclass') ?> <?php $this->text('dir') ?> <?php $this->text('pageclass') ?>">
 
 	<!-- heading -->
-	<div id="mw_header">
-		<h1 id="firstHeading"><?php $this->data['displaytitle']!=""?$this->html('title'):$this->text('title') ?></h1>
-	</div>
+	<div id="mw_header"><h1 id="firstHeading"><?php $this->data['displaytitle']!=""?$this->html('title'):$this->text('title') ?></h1></div>
 
 	<div id="mw_main">
 	<div id="mw_contentwrapper">
Views
Toolbox