MediaWiki r38265 - Code Review

Index: trunk/phase3/includes/specials/SpecialUserrights.php
===================================================================
--- trunk/phase3/includes/specials/SpecialUserrights.php	(revision 38264)
+++ trunk/phase3/includes/specials/SpecialUserrights.php	(revision 38265)
@@ -384,7 +384,7 @@
 				<tr>
 					<td></td>
 					<td class='mw-submit'>" .
-						Xml::submitButton( wfMsg( 'saveusergroups' ), array( 'name' => 'saveusergroups' ) ) .
+						Xml::submitButton( wfMsg( 'saveusergroups' ), array( 'name' => 'saveusergroups', 'accesskey' => 's' ) ) .
 					"</td>
 				</tr>" .
 			Xml::closeElement( 'table' ) . "\n" .
Index: trunk/phase3/includes/specials/SpecialImport.php
===================================================================
--- trunk/phase3/includes/specials/SpecialImport.php	(revision 38264)
+++ trunk/phase3/includes/specials/SpecialImport.php	(revision 38265)
@@ -159,7 +159,7 @@
 				<td>
 				</td>
 				<td>" .
-					Xml::submitButton( wfMsg( 'import-interwiki-submit' ) ) .
+					Xml::submitButton( wfMsg( 'import-interwiki-submit' ), array( 'accesskey' = 's' ) ) .
 				"</td>
 			</tr>" .
 			Xml::closeElement( 'table' ).
Index: trunk/phase3/includes/specials/SpecialExport.php
===================================================================
--- trunk/phase3/includes/specials/SpecialExport.php	(revision 38264)
+++ trunk/phase3/includes/specials/SpecialExport.php	(revision 38265)
@@ -278,7 +278,7 @@
 	//$form .= Xml::checkLabel( wfMsg( 'export-images' ), 'images', 'wpExportImages', false ) . '<br />';
 	$form .= Xml::checkLabel( wfMsg( 'export-download' ), 'wpDownload', 'wpDownload', true ) . '<br />';
 
-	$form .= Xml::submitButton( wfMsg( 'export-submit' ) );
+	$form .= Xml::submitButton( wfMsg( 'export-submit' ), array( 'accesskey' => 's' ) );
 	$form .= Xml::closeElement( 'form' );
 	$wgOut->addHtml( $form );
 }
Index: trunk/phase3/includes/specials/SpecialBlockip.php
===================================================================
--- trunk/phase3/includes/specials/SpecialBlockip.php	(revision 38264)
+++ trunk/phase3/includes/specials/SpecialBlockip.php	(revision 38265)
@@ -246,7 +246,7 @@
 				<td style='padding-top: 1em'>&nbsp;</td>
 				<td  class='mw-submit' style='padding-top: 1em'>" .
 					Xml::submitButton( wfMsg( 'ipbsubmit' ),
-						array( 'name' => 'wpBlock', 'tabindex' => '12' ) ) . "
+						array( 'name' => 'wpBlock', 'tabindex' => '12', 'accesskey' => 's' ) ) . "
 				</td>
 			</tr>" .
 			Xml::closeElement( 'table' ) .
Index: trunk/phase3/includes/specials/SpecialEmailuser.php
===================================================================
--- trunk/phase3/includes/specials/SpecialEmailuser.php	(revision 38264)
+++ trunk/phase3/includes/specials/SpecialEmailuser.php	(revision 38265)
@@ -130,7 +130,7 @@
 <textarea id=\"wpText\" name=\"wpText\" rows='20' cols='80' style=\"width: 100%;\">" . htmlspecialchars( $this->text ) .
 "</textarea>
 " . wfCheckLabel( $emc, 'wpCCMe', 'wpCCMe', $wgUser->getBoolOption( 'ccmeonemails' ) ) . "<br />
-<input type='submit' name=\"wpSend\" value=\"{$ems}\" />
+<input type='submit' name=\"wpSend\" value=\"{$ems}\" accesskey=\"s\" />
 <input type='hidden' name='wpEditToken' value=\"$token\" />
 </form>\n" );
 
Index: trunk/extensions/ParserDiffTest/ParserDiffTest_body.php
===================================================================
--- trunk/extensions/ParserDiffTest/ParserDiffTest_body.php	(revision 38264)
+++ trunk/extensions/ParserDiffTest/ParserDiffTest_body.php	(revision 38265)
@@ -126,7 +126,7 @@
 		$form .= Xml::openElement( 'textarea', array( 'name' => 'pdt_input', 'id' => 'pdt_input', 'rows' => 10, 'cols' => 10 ) );
 		$form .= htmlspecialchars( $text );
 		$form .= Xml::closeElement( 'textarea' );
-		$form .= '<p>' . Xml::submitButton( wfMsg( 'pdtest_ok' ) ) . '&nbsp;&nbsp;' . 
+		$form .= '<p>' . Xml::submitButton( wfMsg( 'pdtest_ok' ), array( 'accesskey' => 's' ) ) . '&nbsp;&nbsp;' . 
 		   Xml::submitButton( wfMsg( 'pdtest_get_text' ), array( 'name' => 'pdt_get_text' ) ) . '</p>';
 		$form .= "</fieldset>\n";
 		$form .= Xml::closeElement( 'form' );
Index: trunk/extensions/ExpandTemplates/ExpandTemplates_body.php
===================================================================
--- trunk/extensions/ExpandTemplates/ExpandTemplates_body.php	(revision 38264)
+++ trunk/extensions/ExpandTemplates/ExpandTemplates_body.php	(revision 38265)
@@ -81,7 +81,7 @@
 		if ( $this->isNewParser ) {
 			$form .= '<p>' . Xml::checkLabel( wfMsg( 'expand_templates_generate_xml' ), 'generate_xml', 'generate_xml', $this->generateXML ) . '</p>';
 		}
-		$form .= '<p>' . Xml::submitButton( wfMsg( 'expand_templates_ok' ) ) . '</p>';
+		$form .= '<p>' . Xml::submitButton( wfMsg( 'expand_templates_ok' ), array( 'accesskey' => 's' ) ) . '</p>';
 		$form .= "</fieldset>\n";
 		$form .= Xml::closeElement( 'form' );
 		return $form;