MediaWiki r37973 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r37972‎ | r37973 (on ViewVC)‎ | r37974 >
Date:19:49, 23 July 2008
Author:simetrical
Status:old
Tags:
Comment:
(bug 8068) New __INDEX__ and __NOINDEX__ magic words allow control of search engine indexing on a per-article basis. Remarks:
* Currently __INDEX__ will override __NOINDEX__ regardless of their relative positions, due to the way things are written. Instead, the last one on the page should win. This should be pretty easy to fix.
* __INDEX__ and __NOINDEX__ override $wgArticleRobotPolicies. This is almost certainly incorrect, but it's not totally obvious how to fix it, because of the way the code is structured. Probably not a big deal, but should probably be fixed at some point.
* Anyone can add and remove the magic words, and there's no config option to disable them. It's not obvious whether this is okay or not. It would be a one-line change to OutputPage.php to have a config option to ignore the magic words, maybe per-namespace or who knows what.
Modified paths:

Diff [purge]

Loading diff…

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r37968Refactor a bit preparatory to fixing bug 8068: rewrite the robot policy stuff...simetrical19:05, 23 July 2008

Status & tagging log

  • 15:29, 12 September 2011 Meno25 (talk | contribs) changed the status of r37973 [removed: ok added: old]