MediaWiki r35213 - Code Review

Jump to: navigation, search
Repository:MediaWiki
Revision:r35212‎ | r35213 (on ViewVC)‎ | r35214 >
Date:01:11, 23 May 2008
Author:simetrical
Status:old
Tags:
Comment:
Re-commit cleaned-up version of r33565 (move subpages along with page).
* Move subpages checkbox is not shown unless the current page or its talk page actually has subpages.
* Move subpages checkbox is shown if subpages are disabled for the current namespace, provided that the talk page has subpages (but then it has no effect unless the "move talk" box is also checked).
* Unnecessary ampersands expunged, superfluous ternary operators excised.
* Crazy 1=0 query removed.
* Limit of maximum number of pages to move at once added (default 1000).

One niggling annoyance is that if the maximum number of pages is hit due to the base page having too many subpages, the talk page probably won't be moved due to the order that results are returned, which is kind of unexpected. Also, make sure the queries don't cause MySQL 4 to explode -- MySQL sometimes has problems with OR, especially older versions. Other than that, should be production-ready, I think.
Modified paths:

Diff [purge]

Loading diff…

Follow-up revisions

Rev.Commit summaryAuthorDate
r35253restore movepage-page-moved from r35213, seems to have been removed by some s...brion21:11, 23 May 2008

Past revisions this follows-up on

Rev.Commit summaryAuthorDate
r33565Users moving a page can now have all subpages automatically moved as well. D...simetrical20:40, 18 April 2008

Status & tagging log

  • 15:27, 12 September 2011 Meno25 (talk | contribs) changed the status of r35213 [removed: ok added: old]